[issue26182] Deprecation warnings for the future async and await keywords in Python 3.6

Change by Serhiy Storchaka : -- pull_requests: -970 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue26182] Deprecation warnings for the future async and await keywords in Python 3.6

Changes by Donald Stufft : -- pull_requests: +970 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue26182] Deprecation warnings for the future async and await keywords in Python 3.6

Roundup Robot added the comment: New changeset 7a996e826f83 by Yury Selivanov in branch '3.6': Issue #26182: Fix ia refleak in code that raises DeprecationWarning. https://hg.python.org/cpython/rev/7a996e826f83 New changeset 7b0e79e7f567 by Yury Selivanov in branch 'default': Merge 3.6 (issue #2

[issue26182] Deprecation warnings for the future async and await keywords in Python 3.6

Brett Cannon added the comment: Sorry I didn't get around to reviewing; I'm sick. On Thu, Sep 15, 2016, 09:51 Yury Selivanov wrote: > > Yury Selivanov added the comment: > > Merged. > > -- > resolution: -> fixed > stage: needs patch -> resolved > status: open -> closed > > ___

[issue26182] Deprecation warnings for the future async and await keywords in Python 3.6

Yury Selivanov added the comment: Merged. -- resolution: -> fixed stage: needs patch -> resolved status: open -> closed ___ Python tracker ___ __

[issue26182] Deprecation warnings for the future async and await keywords in Python 3.6

Roundup Robot added the comment: New changeset 82e6017dc841 by Yury Selivanov in branch '3.6': Issue #26182: Raise DeprecationWarning for improper use of async/await keywords https://hg.python.org/cpython/rev/82e6017dc841 New changeset 3f8b75173543 by Yury Selivanov in branch 'default': Merge 3.

[issue26182] Deprecation warnings for the future async and await keywords in Python 3.6

Yury Selivanov added the comment: I'm going to commit the patch now (I'm going on vacation tomorrow, and I want to watch the buildbots). -- ___ Python tracker ___ __

[issue26182] Deprecation warnings for the future async and await keywords in Python 3.6

Changes by Guido van Rossum : -- nosy: -gvanrossum ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue26182] Deprecation warnings for the future async and await keywords in Python 3.6

Yury Selivanov added the comment: I had to rewrite the patch to make sure it reports correct position and covers all cases where using async/await should trigger a warning. Brett, could you please take a look at the patch? -- Added file: http://bugs.python.org/file44669/issue_26182.pat

[issue26182] Deprecation warnings for the future async and await keywords in Python 3.6

Brett Cannon added the comment: I'm fine with it being in b2 because IMO the warning really should make it in 3.6 and for stuff like this it's more critical to hit the RC for people's testing than the beta to work out semantic changes. -- ___ Python

[issue26182] Deprecation warnings for the future async and await keywords in Python 3.6

Ned Deily added the comment: As long as Brett is also OK with it, it can go in for 360b2. -- ___ Python tracker ___ ___ Python-bugs-li

[issue26182] Deprecation warnings for the future async and await keywords in Python 3.6

Yury Selivanov added the comment: Ned, would it be OK to commit this patch after b1? async/await are scheduled to become real keywords in 3.7. Right now they are only keywords in 'async def' blocks, meaning that it's OK to have a class with 'async' or 'await' attributes. So this will be a ba

[issue26182] Deprecation warnings for the future async and await keywords in Python 3.6

Brett Cannon added the comment: Because parsing is done before execution you can't flip on warnings during runtime in the file you to be affected. As for the line number, that's because it's raise in C code that doesn't have a trigger in Python code. Try importing the code and you should get t

[issue26182] Deprecation warnings for the future async and await keywords in Python 3.6

Changes by Guido van Rossum : -- nosy: -gvanrossum ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue26182] Deprecation warnings for the future async and await keywords in Python 3.6

Marco Buttu added the comment: Thank you Brett, the problem was the missed exec(). With the patch in attachment the tests pass, but it does not seem to me a good solution. Infact, changing the filter at runtime has no effect: $ cat foo.py import warnings warnings.simplefilter("always") asyn

[issue26182] Deprecation warnings for the future async and await keywords in Python 3.6

Changes by STINNER Victor : -- nosy: -haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue26182] Deprecation warnings for the future async and await keywords in Python 3.6

Brett Cannon added the comment: You need to temporarily turn on warnings for it to work. For example: with warnings.catch_warnings(): warnings.simplefilter('always') with self.assertWarnsRegex(DeprecationWarning, "reserved keyword"): exec('async = 33') Do notice I used exe

[issue26182] Deprecation warnings for the future async and await keywords in Python 3.6

Marco Buttu added the comment: I added the PyErr_WarnEx(PyExc_DeprecationWarning, ...) in Python/ast.c, right below the check for None, True and False as names. Running the following test the message is properly printed: def test_async(self): with self.assertWarnsRegex(DeprecationWarning,

[issue26182] Deprecation warnings for the future async and await keywords in Python 3.6

STINNER Victor added the comment: Oh thank. I didn't understand if you wanted to change Python 3.6 or 3.7. -- ___ Python tracker ___ _

[issue26182] Deprecation warnings for the future async and await keywords in Python 3.6

Changes by Brett Cannon : -- title: Deprecation warnings for the future async and await keywords -> Deprecation warnings for the future async and await keywords in Python 3.6 ___ Python tracker ___

[issue26182] Deprecation warnings for the future async and await keywords

STINNER Victor added the comment: Can you please mention the python version in the title? -- ___ Python tracker ___ ___ Python-bugs-li

[issue26182] Deprecation warnings for the future async and await keywords

Yury Selivanov added the comment: Assigning the issue to myself to make sure it won't be forgotten before it's too late. Anish or Marco, feel free to propose a patch. -- assignee: -> yselivanov stage: -> needs patch versions: -Python 3.5 ___ Pyth

[issue26182] Deprecation warnings for the future async and await keywords

Marco Buttu added the comment: Thank you Brett, your explanation (msg259409) and the c-api doc are really straightforward. I think I can fix it in a few days, just the time to read the devguide and be confident about the workflow. -- ___ Python trac

[issue26182] Deprecation warnings for the future async and await keywords

Yury Selivanov added the comment: > I don't know what "softly deprecate" means. Hopefully someone involved with > the PEP can answer that question. I actually thought about emitting DeprecationWarnings in 3.6 for async/await NAME tokens. I think it's a reasonable thing to do to prepare for 3.

[issue26182] Deprecation warnings for the future async and await keywords

Brett Cannon added the comment: I don't know what "softly deprecate" means. Hopefully someone involved with the PEP can answer that question. -- nosy: +gvanrossum ___ Python tracker ___

[issue26182] Deprecation warnings for the future async and await keywords

Changes by Antoine Pitrou : -- nosy: -pitrou ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyth

[issue26182] Deprecation warnings for the future async and await keywords

Anish Shah added the comment: I would like to work on this, if it is okay with Marco? I look at the history of parsetok.c file and I think I can solve this issue. Also, I have a doubt - PEP 492 says that "async and await names will be softly deprecated in CPython 3.5 and 3.6". What exactly doe

[issue26182] Deprecation warnings for the future async and await keywords

Brett Cannon added the comment: I'm not quite sure what you mean by "do not know how to check if the deprecation warning are enabled". Do you mean how do you make sure you don't emit a DeprecationWarning if someone hasn't turned warnings on? If that's the case then if you look at some example

[issue26182] Deprecation warnings for the future async and await keywords

Marco Buttu added the comment: The check for the 'with' statement was handled in the parser (parsetok.c), and in Python 2.5 the warnings were enabled by default. I do not know how to check if the deprecation warning are enabled, otherwise I would have tried to fix the problem. -- ___

[issue26182] Deprecation warnings for the future async and await keywords

Brett Cannon added the comment: If someone wants to try and fix this, I would look at how the warning for the 'with' statement was handled (it will either be in the compiler while generating bytecode or somewhere in the parser, but I'm fairly certain it's the compiler). -- nosy: +bret

[issue26182] Deprecation warnings for the future async and await keywords

Changes by Guido van Rossum : -- nosy: -gvanrossum ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue26182] Deprecation warnings for the future async and await keywords

Changes by Anish Shah : -- nosy: +anish.shah ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue26182] Deprecation warnings for the future async and await keywords

Changes by SilentGhost : -- components: +asyncio nosy: +giampaolo.rodola, gvanrossum, haypo, pitrou, yselivanov ___ Python tracker ___ ___

[issue26182] Deprecation warnings for the future async and await keywords

New submission from Marco Buttu: I saw that async and await will become keywords in Python 3.7 : https://www.python.org/dev/peps/pep-0492/#deprecation-plans I enabled the deprecation warnings in Python 3.5.1 and Python 3.6 dev, and I noticed that assigning to async or await does not issue any