[issue26287] Core dump in f-string with formatting errors

Roundup Robot added the comment: New changeset 9095a5787a82 by Eric V. Smith in branch 'default': Fix issue 26287: While handling FORMAT_VALUE opcode, the top of stack was being corrupted if an error occurred in PyObject_Format(). https://hg.python.org/cpython/rev/9095a5787a82 -- nosy:

[issue26287] Core dump in f-string with formatting errors due to refcount bug

Eric V. Smith added the comment: The problem has to do with refcounting when an error occurs. Adjusting the title accordingly. I'm not sure yet if the problem is in PyObject_Format(), or in handling errors in the eval loop when processing FORMAT_VALUE opcodes. I'm slowly tracking it down. It

[issue26287] Core dump in f-string with formatting errors due to refcount bug

Eric V. Smith added the comment: Yes, that's my thinking as well. I'll have a patch soon-ish. -- ___ Python tracker ___

[issue26287] Core dump in f-string with formatting errors

Eric V. Smith added the comment: Now I think it's not a refcount problem. I'm going to switch to POP/PUSH instead of TOP/SET_TOP. I believe the problem is that I'm not adjusting the top of stack if there's an error. -- title: Core dump in f-string with formatting errors due to

[issue26287] Core dump in f-string with formatting errors

Eric V. Smith added the comment: Thanks for the report and the debugging help. -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker

[issue26287] Core dump in f-string with formatting errors due to refcount bug

Martin Panter added the comment: I have zero experience with with ceval.c but I have a theory after looking over revision 1ddeb2e175df. I suspect “value” is a borrowed reference from TOP(), but at and