[issue26305] Make Argument Clinic to generate PEP 7 conforming code

Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue26305] Make Argument Clinic to generate PEP 7 conforming code

Roundup Robot added the comment: New changeset eeb742d8bf9c by Serhiy Storchaka in branch '3.5': Issue #26305: Argument Clinic now escapes braces. No need to double them. https://hg.python.org/cpython/rev/eeb742d8bf9c New changeset d983c313b8f1 by Serhiy Storchaka in branch 'default': Issue

[issue26305] Make Argument Clinic to generate PEP 7 conforming code

Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka ___ Python tracker ___

[issue26305] Make Argument Clinic to generate PEP 7 conforming code

Serhiy Storchaka added the comment: Here is a patch for 3.5 that allows to not repeat braces too much. This will help to backport new fixes to 3.5. -- Added file: http://bugs.python.org/file42679/clinic_escape_braces.patch ___ Python tracker

[issue26305] Make Argument Clinic to generate PEP 7 conforming code

Larry Hastings added the comment: I'm not excited by this new addition to PEP 7, so I'm excusing myself from this issue. -- ___ Python tracker ___

[issue26305] Make Argument Clinic to generate PEP 7 conforming code

Serhiy Storchaka added the comment: The problem was that I didn't know wherever all braces repeated correct times. Actually they were not used correctly in NoneType_return_converter, but since this converter is not used in current sources, this error left unnoticed. New patch escapes

[issue26305] Make Argument Clinic to generate PEP 7 conforming code

Meador Inge added the comment: LGTM. I agree that the extra braces are a little gross, but nothing immediately comes to mind as how to make that better. -- nosy: +meador.inge ___ Python tracker

[issue26305] Make Argument Clinic to generate PEP 7 conforming code

Serhiy Storchaka added the comment: The only thing that disturbs me is that some templates need duplicating braces, and others need quadrupling braces. -- ___ Python tracker

[issue26305] Make Argument Clinic to generate PEP 7 conforming code

Martin Panter added the comment: FWIW I agree with this change. I left one review comment. I presume the important stuff is just in Tools/clinic/clinic.py and the other changes are all generated code. -- nosy: +martin.panter ___ Python tracker

[issue26305] Make Argument Clinic to generate PEP 7 conforming code

Changes by Serhiy Storchaka : -- components: +Argument Clinic ___ Python tracker ___ ___

[issue26305] Make Argument Clinic to generate PEP 7 conforming code

New submission from Serhiy Storchaka: Proposed patch makes Argument Clinic to generate C code with curly braces as strongly preferred by PEP 7. -- components: Demos and Tools files: clinic_pep7_braces.patch keywords: patch messages: 259836 nosy: brett.cannon, larry, serhiy.storchaka