[issue26384] UnboundLocalError in socket._sendfile_use_sendfile

2016-09-17 Thread Berker Peksag
Changes by Berker Peksag : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue26384] UnboundLocalError in socket._sendfile_use_sendfile

2016-09-17 Thread Roundup Robot
Roundup Robot added the comment: New changeset 78efbf499611 by Berker Peksag in branch '3.5': Issue #26384: Fix UnboundLocalError in socket._sendfile_use_sendfile https://hg.python.org/cpython/rev/78efbf499611 New changeset 2156aa4050c7 by Berker Peksag in branch '3.6': Issue #26384: Merge from

[issue26384] UnboundLocalError in socket._sendfile_use_sendfile

2016-09-17 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: LGTM. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue26384] UnboundLocalError in socket._sendfile_use_sendfile

2016-09-17 Thread Berker Peksag
Changes by Berker Peksag : Added file: http://bugs.python.org/file44721/issue26384_v3.diff ___ Python tracker ___ ___ Python-bugs-list mailing

[issue26384] UnboundLocalError in socket._sendfile_use_sendfile

2016-09-17 Thread Berker Peksag
Berker Peksag added the comment: Thanks, Serhiy. Here's an updated patch. -- versions: +Python 3.7 Added file: http://bugs.python.org/file44720/issue26384_v2.diff ___ Python tracker

[issue26384] UnboundLocalError in socket._sendfile_use_sendfile

2016-02-24 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: This issue can be tested without moking os.fstat(): class F: def fileno(self): return fd with socket.socket() as sock: fd = os.open(os.curdir, os.O_RDONLY) os.close(fd) self.assert

[issue26384] UnboundLocalError in socket._sendfile_use_sendfile

2016-02-18 Thread Berker Peksag
New submission from Berker Peksag: I noticed this while working on issue 16915: Traceback (most recent call last): ... File "/home/berker/projects/cpython/default/Lib/socket.py", line 262, in _sendfile_use_sendfile raise _GiveupOnSendfile(err) # not a regular file UnboundLocalError: lo