[issue26402] Regression in Python 3.5 xmlrpc.client, raises RemoteDisconnected seemingly randomly.

2016-02-25 Thread Jelte Fennema
Jelte Fennema added the comment: No problem, I'm glad to have contributed something to the language I use the most. -- ___ Python tracker ___

[issue26402] Regression in Python 3.5 xmlrpc.client, raises RemoteDisconnected seemingly randomly.

2016-02-25 Thread Martin Panter
Martin Panter added the comment: Thanks for reporting this Jelte -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue26402] Regression in Python 3.5 xmlrpc.client, raises RemoteDisconnected seemingly randomly.

2016-02-25 Thread Roundup Robot
Roundup Robot added the comment: New changeset d668b5595534 by Martin Panter in branch '3.5': Issue #26402: Fix XML-RPC client retrying after server disconnection https://hg.python.org/cpython/rev/d668b5595534 New changeset 70bf0d764939 by Martin Panter in branch 'default': Issue #26402: Merge

[issue26402] Regression in Python 3.5 xmlrpc.client, raises RemoteDisconnected seemingly randomly.

2016-02-22 Thread Martin Panter
Martin Panter added the comment: Here is patch with a test case. I kept Jelte’s original fix as it is, because I want to be conservative in the code changes. Xmlrpc.server only uses HTTP 1.0, without any support of keep-alive connections, so I used http.server instead. -- stage: test

[issue26402] Regression in Python 3.5 xmlrpc.client, raises RemoteDisconnected seemingly randomly.

2016-02-21 Thread Jelte Fennema
Jelte Fennema added the comment: I don't know much about the server as I only used the client. So I don't know if it is possible to test with Python's XML-RPC server. As for your proposed improvement, it seems that should work. Keep in mind though that that would also catch the

[issue26402] Regression in Python 3.5 xmlrpc.client, raises RemoteDisconnected seemingly randomly.

2016-02-21 Thread Martin Panter
Martin Panter added the comment: Thankyou Jelte for finding this. We made RemoteDisconnected inherit from ConnectionResetError (and therefore OSError) thinking it would help with compatibility, but in this case that has backfired. Your patch looks like a valid fix. I would like to figure out

[issue26402] Regression in Python 3.5 xmlrpc.client, raises RemoteDisconnected seemingly randomly.

2016-02-21 Thread Jelte Fennema
Jelte Fennema added the comment: >From what I can see that change simply replaces the old BadStatusLine >exception with the new RemoteDisconnected one. But since BadStatusLine is not >a subclass of OSError the correct code path would be taken. Currently the path >in execpt RemoteDisconnected

[issue26402] Regression in Python 3.5 xmlrpc.client, raises RemoteDisconnected seemingly randomly.

2016-02-21 Thread SilentGhost
SilentGhost added the comment: The code in question[0] was introduced in issue 3566: perhaps Martin could comment on existing implementation. [0] https://hg.python.org/cpython/rev/eba80326ba53 -- components: +Library (Lib) -IO nosy: +SilentGhost, martin.panter stage: -> test needed

[issue26402] Regression in Python 3.5 xmlrpc.client, raises RemoteDisconnected seemingly randomly.

2016-02-21 Thread Jelte Fennema
Changes by Jelte Fennema : -- title: Regression in Python 3.5 http.client, raises RemoteDisconnected seemingly randomly. -> Regression in Python 3.5 xmlrpc.client, raises RemoteDisconnected seemingly randomly. ___ Python