[issue26617] Assertion failed in gc with __del__ and weakref

Change by Ned Deily : -- Removed message: https://bugs.python.org/msg342107 ___ Python tracker ___ ___ Python-bugs-list mailing

[issue26617] Assertion failed in gc with __del__ and weakref

Ned Deily added the comment: New changeset 34fae03cd6c9e304e02c571b3bf9e8df0cfe76be by larryhastings (Serhiy Storchaka) in branch '3.4': [3.4] bpo-26617: Ensure gc tracking is off when invoking weakref callbacks. (#2695)

[issue26617] Assertion failed in gc with __del__ and weakref

Alexander Mohr added the comment: so I just discovered that the object that has the zero refcount has the same tp_dealloc: (gdb) print *FROM_GC(gc)->ob_type $8 = {ob_base = {ob_base = {_ob_next = 0x7f80c8aafc88, _ob_prev = 0x7f80c8aafd00, ob_refcnt = 7, ob_type = 0x7f80cd8c86e0 }, ob_size =

[issue26617] Assertion failed in gc with __del__ and weakref

Alexander Mohr added the comment: I'm tracking something very similar issue to this in bug: http://bugs.python.org/issue31061 Given its similarities, anyone have any ideas? Based on the second callstack I'm starting to think this is an issue with defaultdict -- nosy: +thehesiod

[issue26617] Assertion failed in gc with __del__ and weakref

Changes by Serhiy Storchaka : -- pull_requests: -953 ___ Python tracker ___ ___

[issue26617] Assertion failed in gc with __del__ and weakref

Serhiy Storchaka added the comment: Seems this isn't reproducible with 3.3. -- priority: release blocker -> normal status: open -> closed ___ Python tracker

[issue26617] Assertion failed in gc with __del__ and weakref

Larry Hastings added the comment: Sorry for the delay in merging your PR. I believe Ned is planning to tag the next 3.3 rc1 tomorrow (Sunday). If you see this, and you have time, it'd be great if you could make a PR for the 3.3 backport. Note that 3.3 is probably *not* getting converted to

[issue26617] Assertion failed in gc with __del__ and weakref

Larry Hastings added the comment: New changeset 34fae03cd6c9e304e02c571b3bf9e8df0cfe76be by larryhastings (Serhiy Storchaka) in branch '3.4': [3.4] bpo-26617: Ensure gc tracking is off when invoking weakref callbacks. (#2695)

[issue26617] Assertion failed in gc with __del__ and weakref

Serhiy Storchaka added the comment: I wait merging PR 2695 for cherry-picking it to 3.3. -- ___ Python tracker ___

[issue26617] Assertion failed in gc with __del__ and weakref

Ned Deily added the comment: If it's also reproducible with 3.3, I'd take a 3.3 PR for it. -- ___ Python tracker ___

[issue26617] Assertion failed in gc with __del__ and weakref

Changes by Serhiy Storchaka : -- pull_requests: +2759 ___ Python tracker ___ ___

[issue26617] Assertion failed in gc with __del__ and weakref

Serhiy Storchaka added the comment: I'll do this. -- nosy: +serhiy.storchaka status: closed -> open ___ Python tracker ___

[issue26617] Assertion failed in gc with __del__ and weakref

Larry Hastings added the comment: I'll accept this as a backport for 3.4. I'm convinced that, although the sample programs don't crash in release builds, the behavior is wrong and could be exploited. Will someone have time to create the PR in the next day or two? (It's not that it's

[issue26617] Assertion failed in gc with __del__ and weakref

Changes by Donald Stufft : -- pull_requests: +953 ___ Python tracker ___ ___

[issue26617] Assertion failed in gc with __del__ and weakref

STINNER Victor added the comment: > You should ask for a downstream backport. I created the issue: https://bugzilla.redhat.com/show_bug.cgi?id=1384957 -- ___ Python tracker

[issue26617] Assertion failed in gc with __del__ and weakref

STINNER Victor added the comment: > Would be nice if 3.4 could also be patched, not just 3.5 and 3.6, since > python in EPEL currently is python34-3.4.3-7.el7.x86_64. The patch can be > applied without conflict and resolves some serious cases of segfaults. Sorry but Python 3.4 is not more

[issue26617] Assertion failed in gc with __del__ and weakref

Frens Jan Rumph added the comment: Would be nice if 3.4 could also be patched, not just 3.5 and 3.6, since python in EPEL currently is python34-3.4.3-7.el7.x86_64. The patch can be applied without conflict and resolves some serious cases of segfaults. -- nosy: +Frens Jan Rumph

[issue26617] Assertion failed in gc with __del__ and weakref

Roundup Robot added the comment: New changeset c9b7272e2553 by Benjamin Peterson in branch '3.5': ensure gc tracking is off when invoking weakref callbacks (closes #26617) https://hg.python.org/cpython/rev/c9b7272e2553 New changeset 520cb70ecb90 by Benjamin Peterson in branch '3.6': merge 3.5

[issue26617] Assertion failed in gc with __del__ and weakref

JIahua Guo added the comment: Hi asvetlov, debug mode of python interpreter should be enabled to reproduce this bug, cause assertion is disabled in release mode. (https://hg.python.org/cpython/file/104259/Modules/gcmodule.c#l365) One environment that can reproduce this bug: $ cat /etc/issue

[issue26617] Assertion failed in gc with __del__ and weakref

Andrew Svetlov added the comment: I was unable to reproduce a crash but the patch looks straightforward and obvious. After applying test suite for aiohttp still works without problems at least. -- nosy: +asvetlov ___ Python tracker

[issue26617] Assertion failed in gc with __del__ and weakref

STINNER Victor added the comment: I don't think that the crash is a release blocker, but I just sent an email to python-dev to ask for reviews. -- nosy: +larry, ned.deily priority: normal -> release blocker ___ Python tracker

[issue26617] Assertion failed in gc with __del__ and weakref

Changes by STINNER Victor : -- versions: +Python 3.6, Python 3.7 ___ Python tracker ___

[issue26617] Assertion failed in gc with __del__ and weakref

Changes by Paulus Schoutsen : -- nosy: +balloob ___ Python tracker ___ ___

[issue26617] Assertion failed in gc with __del__ and weakref

Guido van Rossum added the comment: Ben Bangert reported to me that this crash caused instabilities in an app using asyncio (https://github.com/home-assistant/home-assistant/issues/3453). This hack made his crashes go away:

[issue26617] Assertion failed in gc with __del__ and weakref

Changes by Guo, Jiahua : Added file: http://bugs.python.org/file42892/patch ___ Python tracker ___

[issue26617] Assertion failed in gc with __del__ and weakref

Changes by STINNER Victor : -- nosy: +tim.peters ___ Python tracker ___ ___

[issue26617] Assertion failed in gc with __del__ and weakref

STINNER Victor added the comment: Oh, I confirm that the bug occurs on Python 3.5.1+ (3.5 branch) and Python 3.6 (default branch). Call stack: _Py_Dealloc() => subtype_dealloc() => PyObject_ClearWeakRefs() => handle_callback() of weakref => ... => gc_collect => ... => assertion error Full

[issue26617] Assertion failed in gc with __del__ and weakref

Changes by Serhiy Storchaka : -- nosy: +fdrake, haypo, pitrou ___ Python tracker ___ ___

[issue26617] Assertion failed in gc with __del__ and weakref

Changes by Xiang Zhang : -- nosy: +xiang.zhang ___ Python tracker ___ ___ Python-bugs-list

[issue26617] Assertion failed in gc with __del__ and weakref

Changes by Guo Jiahua : -- nosy: +Guo Jiahua ___ Python tracker ___ ___ Python-bugs-list

[issue26617] Assertion failed in gc with __del__ and weakref

Yang Ke added the comment: The crash may be raised on both Windows OS and Linux. We got crashed under Ubuntu 14.04, while a similar issue was found https://bugs.python.org/issue23187#msg238139 last year under Windows OS. We actually raise such bug working on a program with asyncio and

[issue26617] Assertion failed in gc with __del__ and weakref

New submission from Guo, Jiahua: $ python3.5-dbg crash.py python3.5-dbg: ../Modules/gcmodule.c:364: update_refs: Assertion `((gc)->gc.gc_refs >> (1)) != 0' failed. $ python3.5-dbg crash-multithread.py python3.5-dbg: ../Modules/gcmodule.c:364: update_refs: Assertion `((gc)->gc.gc_refs >> (1))