[issue26634] recursive_repr forgets to override __qualname__ of wrapper

Roundup Robot added the comment: New changeset 1f0369547b0e by Serhiy Storchaka in branch '3.5': Issue #26634: recursive_repr() now sets __qualname__ of wrapper. https://hg.python.org/cpython/rev/1f0369547b0e New changeset fb70ea8b7b2d by Serhiy Storchaka in branch 'default': Issue #26634:

[issue26634] recursive_repr forgets to override __qualname__ of wrapper

Changes by Serhiy Storchaka : -- resolution: -> fixed status: open -> closed ___ Python tracker ___

[issue26634] recursive_repr forgets to override __qualname__ of wrapper

Changes by Raymond Hettinger : -- assignee: rhettinger -> serhiy.storchaka ___ Python tracker ___

[issue26634] recursive_repr forgets to override __qualname__ of wrapper

Serhiy Storchaka added the comment: LGTM. I would commit the patch to 3.5 too. -- nosy: +serhiy.storchaka stage: -> commit review versions: +Python 3.5 ___ Python tracker

[issue26634] recursive_repr forgets to override __qualname__ of wrapper

Xiang Zhang added the comment: Hi, Raymond, I've added the test to test the assigned attributes. I use WRAPPER_ASSIGNMENTS in functools so we can keep them consistent. I don't know how to get the original func from the already decorated methods in this case so I define a new container. If

[issue26634] recursive_repr forgets to override __qualname__ of wrapper

Raymond Hettinger added the comment: FWIW, qualname was invented *after* recursive_repr, so it would be more accurate to say that qualname forgot recursive_repr :-) If you don't mind, please add a test to your patch. -- assignee: -> rhettinger nosy: +rhettinger

[issue26634] recursive_repr forgets to override __qualname__ of wrapper

New submission from Xiang Zhang: In reprlib.recursive_repr, it seems __qualname__ is forgotten. Giving the example in reprlib document, it gives a strange result 'recursive_repr..decorating_function..wrapper' of Mylist.__repr__.__qualname__. I simply add the assignment of __qualname__. But I