[issue26687] Use Py_RETURN_NONE in sqlite3 module

2016-04-08 Thread Berker Peksag
Berker Peksag added the comment: Thanks Victor and Serhiy. Сoccinelle looks like a useful tool, but I'm not planning to touch modules that I don't know well enough. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___

[issue26687] Use Py_RETURN_NONE in sqlite3 module

2016-04-08 Thread Roundup Robot
Roundup Robot added the comment: New changeset b72f2d699563 by Berker Peksag in branch 'default': Issue #26687: Use Py_RETURN_NONE macro in sqlite3 module https://hg.python.org/cpython/rev/b72f2d699563 -- nosy: +python-dev ___ Python tracker

[issue26687] Use Py_RETURN_NONE in sqlite3 module

2016-04-01 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: This patch and more can be generated by Сoccinelle [1] semantic patch. spatch --in-place --dir . --sp-file py_return_none_macro.cocci But be aware that some maintainers consider such sort of changes a code churn. [1] http://coccinelle.lip6.fr/

[issue26687] Use Py_RETURN_NONE in sqlite3 module

2016-04-01 Thread STINNER Victor
STINNER Victor added the comment: py_return_none_macro.diff looks good to me. -- nosy: +haypo ___ Python tracker ___

[issue26687] Use Py_RETURN_NONE in sqlite3 module

2016-04-01 Thread Berker Peksag
New submission from Berker Peksag: The attached patch replaces all "Py_INCREF(Py_None); return Py_None;" lines with the Py_RETURN_NONE macro in sqlite3 module. -- components: Extension Modules messages: 262754 nosy: berker.peksag priority: normal severity: normal stage: patch review

[issue26687] Use Py_RETURN_NONE in sqlite3 module

2016-04-01 Thread Berker Peksag
Changes by Berker Peksag : -- keywords: +patch Added file: http://bugs.python.org/file42345/py_return_none_macro.diff ___ Python tracker