[issue26708] Constify C string pointers in the posix module

Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ __

[issue26708] Constify C string pointers in the posix module

Roundup Robot added the comment: New changeset 7edf74098c76 by Serhiy Storchaka in branch 'default': Issue #26708: Use the "const" qualifier for immutable strings. https://hg.python.org/cpython/rev/7edf74098c76 -- nosy: +python-dev ___ Python tracker

[issue26708] Constify C string pointers in the posix module

Eryk Sun added the comment: It looks good to me. There are no errors or warnings. -- ___ Python tracker ___ ___ Python-bugs-list maili

[issue26708] Constify C string pointers in the posix module

Serhiy Storchaka added the comment: Thank you Eryk. Here is updated patch. Is it correct? -- Added file: http://bugs.python.org/file42766/posixmodule_constify2.patch ___ Python tracker _

[issue26708] Constify C string pointers in the posix module

Eryk Sun added the comment: I get the following warnings: ..\Modules\posixmodule.c(7422): warning C4090: 'function': different 'const' qualifiers [...] ..\Modules\posixmodule.c(7423): warning C4090: 'function': different 'const' qualifiers [...] target_is_directory |= _check_dirW(src-

[issue26708] Constify C string pointers in the posix module

Serhiy Storchaka added the comment: Could anyone please try to compile with the patch on Windows and report if there are complile errors? -- components: +Windows nosy: +paul.moore, steve.dower, tim.golden, zach.ware ___ Python tracker

[issue26708] Constify C string pointers in the posix module

Larry Hastings added the comment: You should find a different reviewer. I don't really care about "const". I'll live with it if it's there but I'm not going to go around adding it. -- ___ Python tracker

[issue26708] Constify C string pointers in the posix module

New submission from Serhiy Storchaka: Proposed patch adds the "const" qualifier to char and wchar_t pointers in the posix module to prevents possible bugs. These pointers point to internal data of PyBytes or PyUnicode objects or to C string literals, and unintentional changing the content is a