[issue26917] unicodedata.normalize(): bug in Hangul Composition

Change by Benjamin Peterson : -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___ ___ Python-

[issue26917] unicodedata.normalize(): bug in Hangul Composition

Ma Lin added the comment: This issue can be closed, already fixed in issue29456 Also, PyPy's current code is correct. -- ___ Python tracker ___ __

[issue26917] unicodedata.normalize(): bug in Hangul Composition

Ma Lin added the comment: > Victor's patch is correct. I'm afraid you are wrong. Please see PR 1958 in issue29456, IMO this PR can be merged. -- nosy: +Ma Lin ___ Python tracker _

[issue26917] unicodedata.normalize(): bug in Hangul Composition

Ronan Lamy added the comment: Victor's patch is correct. I implemented the same fix in PyPy in https://bitbucket.org/pypy/pypy/commits/92b4fb5b9e58 -- nosy: +Ronan.Lamy ___ Python tracker ___

[issue26917] unicodedata.normalize(): bug in Hangul Composition

Armin Rigo added the comment: See also https://bitbucket.org/pypy/pypy/issues/2289/incorrect-unicode-normalization . It seems that you reached the same conclusion than the OP in that issue: the problem would really be that normalizing "\uafb8\u11a7" should not drop the second character. Bot

[issue26917] unicodedata.normalize(): bug in Hangul Composition

STINNER Victor added the comment: Attached patch changes Hangul Composition. I'm not sure that it is correct. -- keywords: +patch Added file: http://bugs.python.org/file42691/hangul_composition.patch ___ Python tracker

[issue26917] unicodedata.normalize(): bug in Hangul Composition

STINNER Victor added the comment: Extract of nfc_nfkc(): /* Hangul Composition. We don't need to check for pairs, since we always have decomposed data. */ code = PyUnicode_READ(kind, data, i); if (LBase <= code && code < (LBase+LCount) && i + 1 < len &&

[issue26917] unicodedata.normalize(): bug in Hangul Composition

Changes by STINNER Victor : -- title: Inconsistency in unicodedata.normalize()? -> unicodedata.normalize(): bug in Hangul Composition ___ Python tracker ___