[issue26918] android: test_pipes fails

Xavier de Gaye added the comment: I agree with not complicating tests too much. For the record, the pipes test suite coverage is very low and the code paths that lead to invocations of os.popen() in the pipes module are not tested when those three tests are skipped. -- __

[issue26918] android: test_pipes fails

Serhiy Storchaka added the comment: The equivalent of used "tr" command is .upper(), not .swapcase(). Instead of the loop for s in sys.stdin.read(): sys.stdout.write(s.upper()) you can write just sys.stdout.write(sys.stdin.read().upper()) But actually the loop is needed for testing p

[issue26918] android: test_pipes fails

Xavier de Gaye added the comment: Ooops too late. Here is a new patch that replaces the tr command and allows all the tests of test_pipes to run successfully on android. -- Added file: http://bugs.python.org/file42733/replace_tr.patch ___ Python trac

[issue26918] android: test_pipes fails

Serhiy Storchaka added the comment: LGTM. Thanks Xavier. It looks to me that there are no useful commands that can be used for testing on Android. We could use md5 or grep, but this would require rewriting tests too much for small benefit. It is better to skip tests. -- resolution: -

[issue26918] android: test_pipes fails

Roundup Robot added the comment: New changeset 3bad4b0f7612 by Serhiy Storchaka in branch 'default': Issue #26918: Skipped some tests in test_pipes on Android. https://hg.python.org/cpython/rev/3bad4b0f7612 -- nosy: +python-dev ___ Python tracker

[issue26918] android: test_pipes fails

Xavier de Gaye added the comment: Thanks for the review Serhiy. New patch attached. -- Added file: http://bugs.python.org/file42732/no_tr_skipped_2.patch ___ Python tracker ___ _

[issue26918] android: test_pipes fails

Xavier de Gaye added the comment: Here is the list of commands at /system/bin on the emulator. -- Added file: http://bugs.python.org/file42731/emulator_system_bin.txt ___ Python tracker

[issue26918] android: test_pipes fails

Serhiy Storchaka added the comment: Is tr not available on Android?! I would suggest to use sed instead, but I afraid sed is not available too. What commands are available at all? -- nosy: +serhiy.storchaka ___ Python tracker

[issue26918] android: test_pipes fails

Xavier de Gaye added the comment: The attached patch fixes this. -- keywords: +patch Added file: http://bugs.python.org/file42722/no_tr_skipped.patch ___ Python tracker ___ _

[issue26918] android: test_pipes fails

New submission from Xavier de Gaye: test_pipes fails on an android emulator running an x86 system image at API level 21. root@generic_x86:/data/local/tmp # python -m test -v test_pipes == CPython 3.6.0a0 (default:f4c6dab59cd8+, May 3 2016, 10:42:45) [GCC 4.9 20140827 (prerelease)] == Linux-