[issue27099] IDLE: turn builting extensions into regular modules

Changes by Ned Deily : -- nosy: -ned.deily ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue27099] IDLE: turn builting extensions into regular modules

Terry J. Reedy added the comment: The transferred options belong on the General tab. I have already planned to condense what is there as part of #31051. I held off because I did not know if it would conflict with your patch. Since, as far as I can tell, your patch currently does not touch G

[issue27099] IDLE: turn builting extensions into regular modules

Cheryl Sabella added the comment: zoomheight is OK on Ubuntu. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue27099] IDLE: turn builting extensions into regular modules

Charles Wohlganger added the comment: ZoomHeight has been put back into being an extension. This was because configdialog assumes autoexpand was an extension, and the idleconf tests all need at least one extension to exist to be useful. Zoomheight is pointless in almost any modern desktop envi

[issue27099] IDLE: turn builting extensions into regular modules

Terry J. Reedy added the comment: My 'concern' was in relation to the old situation and why I have become more willing to change default behavior. -- ___ Python tracker ___

[issue27099] IDLE: turn builting extensions into regular modules

Terry J. Reedy added the comment: Before reading the patch, more thoughts on the features, options, and behavior: nothing is Shell only; codecontext, rstrip, and runscript are properly limited to editors; the others are enabled for both. I think paragraph could have been editor only, but I wo

[issue27099] IDLE: turn builting extensions into regular modules

Charles Wohlganger added the comment: I am not sure I understand your concern. As part of mainlining the extensions, all of their keybindings were moved to config-keys.def . There is nothing to prevent users from changing the keybindings or preventing us from making the defaults different acro

[issue27099] IDLE: turn builting extensions into regular modules

Terry J. Reedy added the comment: The main refactoring of ConfigDialog into multiple classes is done. Since you kept this patch up to date with the changes, I will review it next, before making further changing to individual tab pages. On problem with implementing some features as extensions

[issue27099] IDLE: turn builting extensions into regular modules

Terry J. Reedy added the comment: There is a reason that I said, in msg266221, that I would experiment with moving 1 feature ;-). I knew from past experience that changing anything that affected user configuration would have to consider the effect on previous releases. A total 'clean break' n

[issue27099] IDLE: turn builting extensions into regular modules

Charles Wohlganger added the comment: Unfortunately, it looks like config deletes settings for extensions when they are not found - which is what will happen with this patch. One solution would be to have separate config files for 2 and 3. -- ___ Py

[issue27099] IDLE: turn builting extensions into regular modules

Cheryl Sabella added the comment: I don't think a clean break is possible as there's only one set of config files on the system. So, if someone runs Idle 3.7 (this version) and Idle 2.7, they would probably want their settings to be the same for both since that's how it would currently work.

[issue27099] IDLE: turn builting extensions into regular modules

Terry J. Reedy added the comment: 'Clean break' is easy to say. I won't decide yet. Other opinions? I think I will post to idle-dev also. Even if no one responds, there will have been the chance. -- ___ Python tracker

[issue27099] IDLE: turn builting extensions into regular modules

Charles Wohlganger added the comment: The patch moves all config variables to config-main, config-highlight (for highlight colors), and config-keys (for keys). Keys and highlights are configurable in their respective tabs. Parens and Code Context options are in the Highlighting tab, Format Par

[issue27099] IDLE: turn builting extensions into regular modules

Terry J. Reedy added the comment: I am still thinking about how to handle user customization of key defs and values. The current extensions tab does not enable custom key defs, so that would be a new feature, and hence could be handled separately, and normally. I have not yet looked at the p

[issue27099] IDLE: turn builting extensions into regular modules

Terry J. Reedy added the comment: Same place is good for now as testing will be easier. Moving menu items will be a separate issue later. -- ___ Python tracker ___

[issue27099] IDLE: turn builting extensions into regular modules

Charles Wohlganger added the comment: Menus items were placed where they appeared as extensions. It would be no difficulty for me to move them around. -- ___ Python tracker ___

[issue27099] IDLE: turn builting extensions into regular modules

Terry J. Reedy added the comment: Either the hard-coding in the config test will have to be changed or it will have to be replaced by something adaptive. I have not quite decided yet. Once the new tests are merged, I expect to do some followup improvements. Equal important for this issue is

[issue27099] IDLE: turn builting extensions into regular modules

Charles Wohlganger added the comment: Changes to master have introduced tests with hardcoded values for what extensions are expected to be loaded by IDLE. Given that this patch turn all current extensions into mainlined modules, none of them are loaded as extensions and all of the related test

[issue27099] IDLE: turn builting extensions into regular modules

Terry J. Reedy added the comment: I will look at the patch after doing more with config and configdialog. -- ___ Python tracker ___ __

[issue27099] IDLE: turn builting extensions into regular modules

Charles Wohlganger added the comment: Pull Request is passing build tests. Please check for pushing to master at your convenience. -- ___ Python tracker ___

[issue27099] IDLE: turn builting extensions into regular modules

Charles Wohlganger added the comment: Thank you, Cheryl Sabella. I think I've found which tests I've missed running. Now to fix all the bugs... -- ___ Python tracker ___ __

[issue27099] IDLE: turn builting extensions into regular modules

Cheryl Sabella added the comment: When I download the patch and run the tests, I get a lot of warnings (mostly on custom themes and custom keysets). I also get errors in test_parenmatch like this one: ERROR: test_paren_styles (idlelib.idle_test.test_parenmatch.ParenMatchTest) (style='express

[issue27099] IDLE: turn builting extensions into regular modules

Charles Wohlganger added the comment: Pull request won't pass build test, but passes the full idle test on my workstation. Primary cause seems to be: ImportError: cannot import name 'EditorWindow' from 'idlelib.editor' I can also import EditorWindow by itself on my workstation. None of the ch

[issue27099] IDLE: turn builting extensions into regular modules

Changes by Charles Wohlganger : -- pull_requests: +2718 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:/

[issue27099] IDLE: turn builting extensions into regular modules

Terry J. Reedy added the comment: 30779 was merged and backported today. -- ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue27099] IDLE: turn builting extensions into regular modules

Charles Wohlganger added the comment: Progress Update: I've moved all of the basic functionality of the extensions into the regular parts of IDLE, including menus and keyboard shortcuts. parenmatch and codecontext have all of their settings now in the Highlighting settings tab. I have added th

[issue27099] IDLE: turn builting extensions into regular modules

Terry J. Reedy added the comment: This has to wait for at least some of the refactoring and increased testing of configdialog, and maybe for the switch to ttk. -- dependencies: +IDLE: configdialog - add tests for ConfigDialog GUI., IDLE: configdialog -- factor out Changes class, IDLE:

[issue27099] IDLE: turn builting extensions into regular modules

Terry J. Reedy added the comment: I am thinking that we should maybe add an 'Editor' tab. Or we could expand the dialog box. More room on General tab can be obtained by removing the label frames, or at least the labels, which seem a bit redundant. -- versions: +Python 3.7 __

[issue27099] IDLE: turn builting extensions into regular modules

Changes by Terry J. Reedy : -- components: +IDLE ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue27099] IDLE: turn builting extensions into regular modules

Changes by Ned Deily : Added file: http://bugs.python.org/file43385/config-main.def ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue27099] IDLE: turn builting extensions into regular modules

Ned Deily added the comment: Terry, I don't know that much about the history of the config files. I do know that during framework installs of Python on OS X, the "install_IDLE" recipe in Mac/Makefile.in (which ./configure uses to produce a configured Mac/Makefile) has some editing steps, usin

[issue27099] IDLE: turn builting extensions into regular modules

Terry J. Reedy added the comment: Ned, from your response on 20580, there appears to be no conversion rule. Perhap you could go throuch config-main.def and make a list of what you want for Mac and Unix respectively, if different from the current binding. Serhiy, should anything be different

[issue27099] IDLE: turn builting extensions into regular modules

Terry J. Reedy added the comment: Ned, I reread #20580. It reminds me that both Control and Alt are problems. In built-in config-extensions.def, the builtin fixed bindings and one of the configurable bindings are: autocomplete: calltips: parenmatch: runscript: (configurable) I

[issue27099] IDLE: turn builting extensions into regular modules

Terry J. Reedy added the comment: The first line of the last message should have said 'in addition to' instead of 'rather than', In the following expanded table, Key is the number of pseudoevents with configurable and fixed key bindings. Gen is the number of General pseudoevents. (Current, fr

[issue27099] IDLE: turn builting extensions into regular modules

Terry J. Reedy added the comment: The final paragraph of my initial post should have talked about config-main and features, rather than keys. The following experiment indicates that adding new sections to config-main.def and customizations thereof to config-main.cfg should not be a problem.

[issue27099] IDLE: turn builting extensions into regular modules

Terry J. Reedy added the comment: The version conflict problem is why I reverted changing 'extension names' to match the new file names, before rebase collapsing my patches. I was really glad most were in a separate patch. Each time a feature ceases to be an extension, the (old) extension nam

[issue27099] IDLE: turn builting extensions into regular modules

Ned Deily added the comment: I don't have an opinion on the matter, other than a reminder about the current cross-version (and cross-platform) compatibility issues with a user's IDLE configuration files as alluded to in Issue20580. Perhaps others more familiar with IDLE's internals would have

[issue27099] IDLE: turn builting extensions into regular modules

New submission from Terry J. Reedy: Followup to #24225, which renamed idlelib files. Currently, an arbitrary set of 9 (of 10, if Check Module is counted as a separate feature) IDLE features are implemented as extensions. Their menu names are as follows: Edit - Show Completions Edit - Expa

[issue27099] IDLE: turn builting extensions into regular modules

Changes by Terry J. Reedy : -- dependencies: +Idlelib: changing file names ___ Python tracker ___ ___ Python-bugs-list mailing list Un