[issue27113] sqlite3 connect parameter "check_same_thread" not documented

Thomas Kluyver added the comment: Congrats! :-) -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue27113] sqlite3 connect parameter "check_same_thread" not documented

Dave Sawyer added the comment: hurray! My first commit -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https

[issue27113] sqlite3 connect parameter "check_same_thread" not documented

Roundup Robot added the comment: New changeset af1752e51a89 by Senthil Kumaran in branch '3.5': issue27113 - Document "check_same_thread" parameter in sqlite3.connect api. https://hg.python.org/cpython/rev/af1752e51a89 New changeset 17c8da643065 by Senthil Kumaran in branch 'default': [merge fro

[issue27113] sqlite3 connect parameter "check_same_thread" not documented

Senthil Kumaran added the comment: Thanks for your contribution. It's now documented. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker _

[issue27113] sqlite3 connect parameter "check_same_thread" not documented

Senthil Kumaran added the comment: Thanks for the explanation, Dave. Completely agree with those points. Let's go ahead with the latest patch. -- ___ Python tracker ___

[issue27113] sqlite3 connect parameter "check_same_thread" not documented

Dave Sawyer added the comment: Hi Thomas and Senthil, for the serialized setting I mentioned earlier "The serialized mode is default on both Mac and Windows so we can probably skip validating that. I did like mentioning the user needs to serialize the writes. They could use one thread for writ

[issue27113] sqlite3 connect parameter "check_same_thread" not documented

Thomas Kluyver added the comment: That comment contained far too much 'probably'. Time for me to sleep... -- ___ Python tracker ___ __

[issue27113] sqlite3 connect parameter "check_same_thread" not documented

Thomas Kluyver added the comment: Having watched the video of Dave's PyCon talk (thanks Dave), I think he's talking about using locking to control transactions, which presumably the sqlite bindings don't handle by themselves. But I don't *think* you need manual locking just to maintain databas

[issue27113] sqlite3 connect parameter "check_same_thread" not documented

Senthil Kumaran added the comment: Dave, your patch looks good to me. Did you see the comment from Trevor on your first patch? >> According to the sqlite docs (http://www.sqlite.org/threadsafe.html), the default mode is 'serialized', which does the necessary locking for threads to share a conne

[issue27113] sqlite3 connect parameter "check_same_thread" not documented

Dave Sawyer added the comment: Changed doc to note that not only must it be used on 1 thread if true, but that thread must be the thread that created it. -- ___ Python tracker _

[issue27113] sqlite3 connect parameter "check_same_thread" not documented

Dave Sawyer added the comment: The user probably has a recent enough version. This is guaranteed on Windows since Python bundles 3.6 or later. On mac or Linux it will use the version installed on the machine. I'll make a separate patch to check the version in sqlite3.py so it will give an erro

[issue27113] sqlite3 connect parameter "check_same_thread" not documented

Senthil Kumaran added the comment: Thanks for the review. Made it both singular in the updated patch. * As for why the default value was chosen to be to True, I think, the reason is pysqlite, from sqlite3 module was derived, did not support this option when it was introduced. I still do not fi

[issue27113] sqlite3 connect parameter "check_same_thread" not documented

Dave Sawyer added the comment: The revised patch says "connections" plural for true and "connection" singular for false. How about "the connection" since the method returns a connection. I'm wondering though about the lack of explanation or WHY for this parameter. As written it seems like the

[issue27113] sqlite3 connect parameter "check_same_thread" not documented

Senthil Kumaran added the comment: We should be able to simplify this further based on the comments in the review for the first patch. Please find my patch issue27113-rev2.patch attached. -- Added file: http://bugs.python.org/file43053/issue27113-rev2.patch ___

[issue27113] sqlite3 connect parameter "check_same_thread" not documented

Senthil Kumaran added the comment: Thank you for the patch, Dave. Following the language style of rest of the docs, check_same_thread, should be explained in a passive voice. Also, mentioning the version requirement at this place, does not seem suitable to me. When we provide this feature, it

[issue27113] sqlite3 connect parameter "check_same_thread" not documented

Changes by Thomas Kluyver : -- nosy: +takluyver ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue27113] sqlite3 connect parameter "check_same_thread" not documented

Changes by Berker Peksag : -- stage: needs patch -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue27113] sqlite3 connect parameter "check_same_thread" not documented

Berker Peksag added the comment: This is a duplicate of issue 16509, but I'm going to keep this open since there is a patch attached here. -- nosy: +berker.peksag stage: -> needs patch versions: +Python 3.5 ___ Python tracker

[issue27113] sqlite3 connect parameter "check_same_thread" not documented

Changes by Dave Sawyer : -- title: sqlite3 open parameter "check_same_thread" not documented -> sqlite3 connect parameter "check_same_thread" not documented ___ Python tracker _