[issue27222] redundant checks and a weird use of goto statements in long_rshift

2017-03-31 Thread Donald Stufft
Changes by Donald Stufft : -- pull_requests: +1066 ___ Python tracker ___ ___

[issue27222] redundant checks and a weird use of goto statements in long_rshift

2016-09-17 Thread Mark Dickinson
Mark Dickinson added the comment: Thanks for the patch and the thorough analysis! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue27222] redundant checks and a weird use of goto statements in long_rshift

2016-09-17 Thread Roundup Robot
Roundup Robot added the comment: New changeset 21b70c835b5b by Mark Dickinson in branch 'default': Issue #27222: various cleanups in long_rshift. Thanks Oren Milman. https://hg.python.org/cpython/rev/21b70c835b5b -- nosy: +python-dev ___ Python

[issue27222] redundant checks and a weird use of goto statements in long_rshift

2016-09-13 Thread Mark Dickinson
Mark Dickinson added the comment: Sorry, this fell off my list of things to look at. -- assignee: -> mark.dickinson ___ Python tracker ___

[issue27222] redundant checks and a weird use of goto statements in long_rshift

2016-09-13 Thread Oren Milman
Changes by Oren Milman : -- versions: +Python 3.7 -Python 3.6 ___ Python tracker ___ ___

[issue27222] redundant checks and a weird use of goto statements in long_rshift

2016-06-04 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- nosy: +mark.dickinson, serhiy.storchaka stage: -> patch review versions: +Python 3.6 ___ Python tracker

[issue27222] redundant checks and a weird use of goto statements in long_rshift

2016-06-04 Thread Oren Milman
Changes by Oren Milman : Added file: http://bugs.python.org/file43208/CPythonTestOutput.txt ___ Python tracker ___

[issue27222] redundant checks and a weird use of goto statements in long_rshift

2016-06-04 Thread Oren Milman
Changes by Oren Milman : Added file: http://bugs.python.org/file43209/patchedCPythonTestOutput.txt ___ Python tracker ___

[issue27222] redundant checks and a weird use of goto statements in long_rshift

2016-06-04 Thread Oren Milman
New submission from Oren Milman: current state 1. long_rshift first checks whether a is a negative int. If it is, it does (edited for brevity) 'z = long_invert(long_rshift(long_invert(a), b));'. Otherwise, it calculates the result of the shift and stores it in z. In