[issue27309] Visual Styles support to tk/tkinter file and message dialogs

2016-07-17 Thread Steve Dower
Steve Dower added the comment: Updated the manifest to include the correct common controls DLL, which ensures the correct style is used for native dialogs. I applied this to Python 3.5 and 3.6, since it's not a behavioural change and should not break any code, and arguably since it's been the

[issue27309] Visual Styles support to tk/tkinter file and message dialogs

2016-07-17 Thread Roundup Robot
Roundup Robot added the comment: New changeset 7ffb7f3c345d by Steve Dower in branch '3.5': Issue #27309: Enables proper Windows styles in python[w].exe manifest. https://hg.python.org/cpython/rev/7ffb7f3c345d New changeset da735eb8b7a2 by Steve Dower in branch 'default': Issue #27309: Enables p

[issue27309] Visual Styles support to tk/tkinter file and message dialogs

2016-06-21 Thread Steve Dower
Steve Dower added the comment: > Would it be possible to tie this to _tkinter.pyd instead of python{w}.exe? Afraid not, Windows needs to load a different version of a particular DLL for the entire process. But at this stage it shouldn't negatively affect anyone. I'd even be okay adding it into

[issue27309] Visual Styles support to tk/tkinter file and message dialogs

2016-06-21 Thread Zachary Ware
Zachary Ware added the comment: I wonder whether this manifest change would affect other GUI toolkit packages (though frankly I'm having trouble finding any others that work with Python 3 on Windows...), positively or negatively. Would it be possible to tie this to _tkinter.pyd instead of pyt

[issue27309] Visual Styles support to tk/tkinter file and message dialogs

2016-06-21 Thread Steve Dower
Steve Dower added the comment: If someone wants to make a patch, the manifest we embed is in PC/python.manifest -- ___ Python tracker ___

[issue27309] Visual Styles support to tk/tkinter file and message dialogs

2016-06-20 Thread Terry J. Reedy
Terry J. Reedy added the comment: Pat, thank you for the explanation, xml, and link. I was a bit confused by the overlapping yet different meanings of 'ttk theme' and 'Windows theme'. For 3.6, I am converting IDLE to use ttk widgets. From the example on the SO page, which links to https://i.

[issue27309] Visual Styles support to tk/tkinter file and message dialogs

2016-06-20 Thread Pat Thoyts
Pat Thoyts added the comment: As explained in the SO answer, in Tk on Windows the messagebox, file open dialog, save as dialog and in 8.6 up the font dialog are all system standard dialogs. Tk gets Windows to show the common dialog or messagebox and just wraps the Win32 API calls. As a result

[issue27309] Visual Styles support to tk/tkinter file and message dialogs

2016-06-20 Thread [HYBRID BEING]
[HYBRID BEING] added the comment: Ok, you sorta lost me. Would patthoyts's solution not work with Tk <8.5? As i understood (which i may did wrong), message box is returned by system (or is it actually Tk, and not system?), and it uses styled/non-styled controls based on calling process manifes

[issue27309] Visual Styles support to tk/tkinter file and message dialogs

2016-06-17 Thread Terry J. Reedy
Terry J. Reedy added the comment: tkinter.messagebox is based on tkinter.commondialog, first written in 1997. Since it works as originally designed, it does not seem to have been significantly altered since before themed widgets. Upgrading would be an enhancement for future versions, not a bug

[issue27309] Visual Styles support

2016-06-13 Thread [HYBRID BEING]
New submission from [HYBRID BEING]: This answer (http://stackoverflow.com/questions/33792008/python-tkinter-ttk-themed-message-box/33801260#33801260) to the Stack Overflow question states that Tkinter's messageboxes use non-themed controls due to the fact that python.exe and pythonw.exe lack