[issue27455] Fix tkinter examples to be PEP8 compliant

Berker Peksag added the comment: Since Terry is already busy with IDLE maintenance, I went ahead and commit the patch with minor modifications. Thanks for the patch, John! :) -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___

[issue27455] Fix tkinter examples to be PEP8 compliant

Roundup Robot added the comment: New changeset 453a88a41a58 by Berker Peksag in branch '3.5': Issue #27455: Improve examples in tkinter documentation https://hg.python.org/cpython/rev/453a88a41a58 New changeset 800c069e16a0 by Berker Peksag in branch 'default': Issue #27455: Merge from 3.5 https

[issue27455] Fix tkinter examples to be PEP8 compliant

John Hagen added the comment: The patch was reviewed and marked ready to commit. Could someone with commit privileges perform the final commit? Thanks. -- ___ Python tracker _

[issue27455] Fix tkinter examples to be PEP8 compliant

John Hagen added the comment: @Berker, thanks for the tip! I've fixed it up. I think this latest patch covers everything Berker and Terry have commented about. -- Added file: http://bugs.python.org/file43645/Fix-tkinter-docs-PEP8.diff ___ Python tra

[issue27455] Fix tkinter examples to be PEP8 compliant

Changes by John Hagen : Removed file: http://bugs.python.org/file43641/0001-Fix-tkinter-docs-PEP8.diff ___ Python tracker ___ ___ Python-bugs-

[issue27455] Fix tkinter examples to be PEP8 compliant

Berker Peksag added the comment: Thanks for the updated patch. I noticed a typo in your test script. It works for me if I update the super() line from super().__init__(self, master) to super().__init__(master) -- ___ Python tracker

[issue27455] Fix tkinter examples to be PEP8 compliant

John Hagen added the comment: @Terry I've removed the two string quotes changes in the latest patch. @Berker I spent a small amount of time trying out your proposed super() changes, but could not get them to work on 3.5.1. "C:\Users\John Hagen\AppData\Local\Programs\Python\Python35\python.exe"

[issue27455] Fix tkinter examples to be PEP8 compliant

Changes by John Hagen : Removed file: http://bugs.python.org/file43628/0001-Fix-tkinter-docs-PEP8.diff ___ Python tracker ___ ___ Python-bugs-

[issue27455] Fix tkinter examples to be PEP8 compliant

John Hagen added the comment: @Terry The reason for changing the quotes was for consistency, since everywhere else on that page used double quotes. That being said, I don't have a strong preference and will happily revert it if that is the consensus. I'm +0 on the change. I personally use sin

[issue27455] Fix tkinter examples to be PEP8 compliant

Changes by Terry J. Reedy : -- components: +Tkinter ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue27455] Fix tkinter examples to be PEP8 compliant

Terry J. Reedy added the comment: Except for replacing '' with ""*, I am strongly for this patch. To me, caMelcaSe is ugLy, and should not be encouraged. I disagree that camelCase is standard convention, at least not currently. Tkinter itself does not use it. It does not even use TitleCase

[issue27455] Fix tkinter examples to be PEP8 compliant

John Hagen added the comment: @Berker, sorry for the incorrect diff format, still new to CPython (and Mercurial) workflow. I've attached the diff in a new format. @SilentGhost I see what you mean that camelCase is used often in tkinter (though many of the examples use lower_camel_case, so it

[issue27455] Fix tkinter examples to be PEP8 compliant

Changes by John Hagen : Removed file: http://bugs.python.org/file43627/0001-Fix-tkinter-docs-PEP8.patch ___ Python tracker ___ ___ Python-bugs

[issue27455] Fix tkinter examples to be PEP8 compliant

Berker Peksag added the comment: Thanks for the patch. If you want to improve the examples in tkinter documentation, I'd suggest to update Class.__init__(self, ...) to super().__init__(...). There is no old-style classes in Python 3 anymore so those examples could be updated safely. Also, ple

[issue27455] Fix tkinter examples to be PEP8 compliant

SilentGhost added the comment: This patch is going to be rejected, camelCase is standard convention in tkinter and logging modules and that's why it is used in documentation as well. -- nosy: +SilentGhost ___ Python tracker

[issue27455] Fix tkinter examples to be PEP8 compliant

New submission from John Hagen: Patch fixes tkinter examples to be PEP8 compliant. -- assignee: docs@python components: Documentation files: 0001-Fix-tkinter-docs-PEP8.patch keywords: patch messages: 269820 nosy: John Hagen, docs@python priority: normal severity: normal status: open titl