Benjamin Peterson [EMAIL PROTECTED] added the comment:
Let's see:
1. Fix up and add to trunk. Check!
2. Convert docs to reST. Check!
3. Port to 3.0. Check!
4. Fix docs in 3.0. Check!
Yes, we can close this.
--
resolution: - accepted
status: open - closed
Brett Cannon [EMAIL PROTECTED] added the comment:
Can this issue be closed?
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2750
__
___
Python-bugs-list mailing list
Unsubscribe:
Christian Heimes [EMAIL PROTECTED] added the comment:
Command to merge json into 3.0:
svnmerge.py unblock -r62734,62736,62748,62769; svnmerge.py merge --force
-r62734,62736,62748,62769
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2750
Benjamin Peterson [EMAIL PROTECTED] added the comment:
On Wed, May 7, 2008 at 7:08 PM, Christian Heimes [EMAIL PROTECTED] wrote:
Christian Heimes [EMAIL PROTECTED] added the comment:
Command to merge json into 3.0:
svnmerge.py unblock -r62734,62736,62748,62769; svnmerge.py merge --force
Christian Heimes [EMAIL PROTECTED] added the comment:
Because I haven't committed the result of svnmerge.py unblock yet.
svnmerge.py refuses to work on a sandbox with uncommitted changes.
2to3:
./python Tools/scripts/2to3 -w Lib/json/
./python Tools/scripts/2to3 -w -d Lib/json/
Christian Heimes [EMAIL PROTECTED] added the comment:
I got the JSON module working under Python 3.0. I'm still not happy with
the mixing of bytes and unicode, though.
The patch contains additional changes to svnmerge.py unblock
-r62734,62736,62748,62769; svnmerge.py merge --force
Benjamin Peterson [EMAIL PROTECTED] added the comment:
When you've merged it, I'll alter the 3.0 docs.
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2750
__
___
Christian Heimes [EMAIL PROTECTED] added the comment:
The Python 3.0 port is going to be tricky. Can somebody with more
knowledge about the code please annotate which methods accept/return
bytes and/or unicode?
__
Tracker [EMAIL PROTECTED]
Bob Ippolito [EMAIL PROTECTED] added the comment:
loads will take unicode or str. if it's str then it assumes utf-8,
otherwise the explicitly specified encoding. All of the string instances
generated by loads will be unicode objects (some of them may be str
objects if they're all ASCII as an
Christian Heimes [EMAIL PROTECTED] added the comment:
Since dumps and loads deal with raw data they should accept/return
bytes, too.
I'm re-adding 2.6 as version again because I believe we should clean up
the API in 2.6 first. It's also a good chance to document how to port a
library to Python
Christian Heimes [EMAIL PROTECTED] added the comment:
Please merge the bzr into the svn trunk as soon as possible. I'd like to
get it into the last alpha release.
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2750
__
Brett Cannon [EMAIL PROTECTED] added the comment:
I am leaving this issue open until 'json' is ported to 3.0 (and thus why I
am assigning this to Christian).
--
assignee: benjamin.peterson - christian.heimes
__
Tracker [EMAIL PROTECTED]
Changes by Brett Cannon [EMAIL PROTECTED]:
--
versions: -Python 2.6
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2750
__
___
Python-bugs-list mailing list
Georg Brandl [EMAIL PROTECTED] added the comment:
Fixed up the docs in r62736.
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2750
__
___
Python-bugs-list mailing list
Brett Cannon [EMAIL PROTECTED] added the comment:
One problem with the way the patch is now is that it will fail on non-
CPython interpreters the way it is currently coded. For instance,
json/decoder.py completely assumes that importing _json will succeed. Same
with the test suite.
Will need
Bob Ippolito [EMAIL PROTECTED] added the comment:
It doesn't work on alternate implementations right now anyway, because
it (ab)uses some sre APIs that aren't widely implemented outside of cpython.
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2750
Brett Cannon [EMAIL PROTECTED] added the comment:
Ouch. Well then hopefully either they will get implemented or some way to
not rely on them can be developed.
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2750
__
Bob Ippolito [EMAIL PROTECTED] added the comment:
it's isolated to json.scanner, if that was re-implemented in more
general terms then it wouldn't be dependent on sre anymore.
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2750
Benjamin Peterson [EMAIL PROTECTED] added the comment:
BTW, the regression for not executing packages was intented. See #2751.
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2750
__
Bob Ippolito [EMAIL PROTECTED] added the comment:
Well, that's unfortunate. I found it very useful
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2750
__
___
Python-bugs-list
Benjamin Peterson [EMAIL PROTECTED] added the comment:
I've committed the reST docs. Bob, do you want to have a look?
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2750
__
___
Bob Ippolito [EMAIL PROTECTED] added the comment:
They look good, but is there an easy way to look at them post-formatting
or do I have to install the sphinx toolchain myself?
I moved the command-line stuff to json.tool to get around the package
problem.
__
Georg Brandl [EMAIL PROTECTED] added the comment:
Benjamin, if you want you can send me the rst file for review. I tried
to checkout the bzr branch, but cancelled it after waiting for 25 minutes.
--
nosy: +georg.brandl
__
Tracker [EMAIL PROTECTED]
Bob Ippolito [EMAIL PROTECTED] added the comment:
I don't think that makes sense, tool makes it pretty clear that it's
something you use from the command-line rather than a module to import
and call functions from where pp does not.
I'd also rather call it pprint than pp if that were the
Benjamin Peterson [EMAIL PROTECTED] added the comment:
Georg, I'm attaching json.rst.
Bob, I personally would prefer pprint, but it's your choice.
Added file: http://bugs.python.org/file10195/json.rst
__
Tracker [EMAIL PROTECTED]
Benjamin Peterson [EMAIL PROTECTED] added the comment:
On Sun, May 4, 2008 at 12:56 PM, Bob Ippolito [EMAIL PROTECTED] wrote:
Bob Ippolito [EMAIL PROTECTED] added the comment:
They look good, but is there an easy way to look at them post-formatting
or do I have to install the sphinx
Benjamin Peterson [EMAIL PROTECTED] added the comment:
When we're ready, I'll merge this into the trunk and Py3k. (There are no
Py3k warnings on test, so it should only be a matter of running 2to3.)
--
assignee: - benjamin.peterson
__
Tracker [EMAIL
Christian Heimes [EMAIL PROTECTED] added the comment:
The ref leak and unit tests are passing on Windows, too. I'm going to
change the import of the C extension and then you can commit the bzr
branch into the trunk.
For 3.0 the C module probably needs some changes. I'll look into it once
the
Philip Jenvey [EMAIL PROTECTED] added the comment:
Bob, all of the simplejson tests have actually been passing on Jython
trunk -- at least up until recently when you added a couple tests that
utilize the 2.4 decimal module.
I can also import simplejson.scanner with a recent build of pypy, so
New submission from Bob Ippolito [EMAIL PROTECTED]:
Attached is the tarball for simplejson 1.9, the proposed version to be
included in the stdlib.
Estimated work remaining:
* Rename simplejson to json
* Build simplejson/_speedups.c from Modules/Setup and Windows projects
* Convert
Benjamin Peterson [EMAIL PROTECTED] added the comment:
This work might be a good thing to a do on a Bazaar branch.
--
nosy: +benjamin.peterson
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2750
__
Changes by Brett Cannon [EMAIL PROTECTED]:
--
keywords: +patch
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2750
__
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Brett Cannon [EMAIL PROTECTED]:
--
priority: - critical
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2750
__
___
Python-bugs-list mailing list
Brett Cannon [EMAIL PROTECTED] added the comment:
The most critical steps are to get the code building and to get the tests
passing. Once that is working the code can be checked in and the other
steps (docs, PEP 7/8, 3.0 conversion) can happen after the fact.
--
nosy: +brett.cannon
Christian Heimes [EMAIL PROTECTED] added the comment:
Yeah, either make a bzr branch or an ordinary svn branch. If you need
some help with the C code I can be of assistance. I'm in #python-dev.
Let's coordinate the next steps there.
--
nosy: +tiran
__
Brett Cannon [EMAIL PROTECTED] added the comment:
On Sat, May 3, 2008 at 3:19 PM, Christian Heimes [EMAIL PROTECTED] wrote:
Christian Heimes [EMAIL PROTECTED] added the comment:
Yeah, either make a bzr branch or an ordinary svn branch. If you need
some help with the C code I can be of
Brett Cannon [EMAIL PROTECTED] added the comment:
Branch is at http://code.python.org/python/users/brett/issue2750-
simplejson/ .
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2750
__
Brett Cannon [EMAIL PROTECTED] added the comment:
Just so it is documented, Bob said on IRC that we do not need to keep
compatibility with any specific version of Python.
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2750
Benjamin Peterson [EMAIL PROTECTED] added the comment:
I'll do PEP 8 review.
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2750
__
___
Python-bugs-list mailing list
Bob Ippolito [EMAIL PROTECTED] added the comment:
The json package is in brett's branch, integrates with the test suite,
builds the C extension and passes all tests (at least on OS X and Linux
UCS2 and UCS4).
Missing the docs and python 3.0 support still, otherwise things look good.
Benjamin Peterson [EMAIL PROTECTED] added the comment:
I'm going to handle the docs, too.
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2750
__
___
Python-bugs-list mailing
41 matches
Mail list logo
