[issue27570] Avoid memcpy(. . ., NULL, 0) etc calls

Changes by Martin Panter : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue27570] Avoid memcpy(. . ., NULL, 0) etc calls

Roundup Robot added the comment: New changeset d465da1e5902 by Martin Panter in branch '2.7': Issue #27570: Avoid zero-length memcpy() calls with null source pointers https://hg.python.org/cpython/rev/d465da1e5902 -- ___ Python tracker

[issue27570] Avoid memcpy(. . ., NULL, 0) etc calls

Roundup Robot added the comment: New changeset e231dcad3a9b by Martin Panter in branch '3.5': Issue #27570: Avoid zero-length memcpy() calls with null source pointers https://hg.python.org/cpython/rev/e231dcad3a9b New changeset 2d0fb659372c by Martin Panter in branch 'default': Issue #27570: Mer

[issue27570] Avoid memcpy(. . ., NULL, 0) etc calls

Benjamin Peterson added the comment: Sorry I missed this. The changes which I didn't already make look good. :) -- ___ Python tracker ___

[issue27570] Avoid memcpy(. . ., NULL, 0) etc calls

Martin Panter added the comment: Looks like revisions 5f3f6f1fb73a and ec537f9f468f may have fixed the listobject cases. Also 66feda02f2a5 looks relevant. Benjamin, maybe you are interested in other bits of my patches :) -- nosy: +benjamin.peterson ___

[issue27570] Avoid memcpy(. . ., NULL, 0) etc calls

Martin Panter added the comment: Patch 3 fixes some more cases I found in the array module: >>> a + a Modules/arraymodule.c:809:5: runtime error: null pointer passed as argument 1, which is declared to never be null Modules/arraymodule.c:809:5: runtime error: null pointer passed as argument 2,

[issue27570] Avoid memcpy(. . ., NULL, 0) etc calls

Martin Panter added the comment: V2 patch adds another fix, uncovered by recent datetime tests: >>> a = array("B") >>> a[:] = a /media/disk/home/proj/python/cpython/Modules/arraymodule.c:748:5: runtime error: null pointer passed as argument 1, which is declared to never be null /media/disk/home

[issue27570] Avoid memcpy(. . ., NULL, 0) etc calls

New submission from Martin Panter: This patch fixes errors reported by GCC’s undefined behaviour sanitizer about calling functions with a null pointer: ./configure CC="gcc -fsanitize=undefined" Using Issue 22605 as a precedent, I propose to avoid calling memcpy() and memmove() for zero-length