[issue27721] distutils strtobool returns 0 and 1 rather than False and True

Change by Nathaniel Manista : -- nosy: +Nathaniel Manista ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue27721] distutils strtobool returns 0 and 1 rather than False and True

Changes by SilentGhost : -- resolution: not a bug -> wont fix stage: patch review -> resolved ___ Python tracker ___

[issue27721] distutils strtobool returns 0 and 1 rather than False and True

Raymond Hettinger added the comment: Sorry Joseph, I concur that with Ned that we're best off leaving this alone (risk of breaking doctests with the changing repr, risk of fooling an overly specific type test, etc). The code is not incorrect and does correspond with its docstring which

[issue27721] distutils strtobool returns 0 and 1 rather than False and True

Joseph Bane added the comment: Thank you for your feedback. I definitely understand your reasoning and commitment to not introducing breaking changes in externally facing codes. I also agree that this does fall slightly more on the side of aesthetic rather than functional changes. However,

[issue27721] distutils strtobool returns 0 and 1 rather than False and True

Ned Deily added the comment: Joseph, thanks for taking an interest in improving Python and submitting this patch. Alas, I don't think we should apply it. There are always tradeoffs that have to be considered when changing existing code. Distutils is one of the oldest and most external

[issue27721] distutils strtobool returns 0 and 1 rather than False and True

Berker Peksag added the comment: Could you also update documentation in Doc/distutils/apiref.rst? Also, test_strtobool in Lib/distutils/tests/test_util.py doesn't test the following case: >>> from distutils.util import strtobool >>> strtobool('x') Traceback (most recent call

[issue27721] distutils strtobool returns 0 and 1 rather than False and True

SilentGhost added the comment: LGTM -- stage: -> commit review ___ Python tracker ___ ___ Python-bugs-list

[issue27721] distutils strtobool returns 0 and 1 rather than False and True

Joseph Bane added the comment: Thank you for the feedback. Please find an updated patch attached. -- Added file: http://bugs.python.org/file44061/patch.diff ___ Python tracker

[issue27721] distutils strtobool returns 0 and 1 rather than False and True

SilentGhost added the comment: Couple of things: your patch doesn't seem to apply cleanly for whatever reason (most likely because it's a patch against python2); the change from lowercasing to casefolding doesn't seem justified to me; the formatted value needs to be repr-formatted - though

[issue27721] distutils strtobool returns 0 and 1 rather than False and True

Changes by R. David Murray : -- title: strtobool returns 0 and 1 rather than False and True -> distutils strtobool returns 0 and 1 rather than False and True ___ Python tracker

[issue27721] distutils strtobool returns 0 and 1 rather than False and True

Changes by R. David Murray : -- versions: +Python 3.6 -Python 2.7, Python 3.5 ___ Python tracker ___