[issue27755] Retire DynOptionMenu with a ttk Combobox

Change by Mark Roseman : -- pull_requests: +7590 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue27755] Retire DynOptionMenu with a ttk Combobox

Terry J. Reedy added the comment: Yes, we should use ttk.Spinbox: #33962. -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue27755] Retire DynOptionMenu with a ttk Combobox

Mark Roseman added the comment: Given the difference between the old and new (ttk) spinbox, especially on macOS, I'd like to incorporate it into IDLE when available. See screenshot spinbox.png, noting white border around old one. Terry, can we add a spinbox wrapper to IDLE for the time

[issue27755] Retire DynOptionMenu with a ttk Combobox

Changes by Cheryl Sabella : -- pull_requests: +3482 stage: test needed -> patch review ___ Python tracker ___

[issue27755] Retire DynOptionMenu with a ttk Combobox

Cheryl Sabella added the comment: Maybe there should be a bug tracker issue to add it to ttk.py? -- ___ Python tracker ___

[issue27755] Retire DynOptionMenu with a ttk Combobox

Mark Roseman added the comment: Cheryl, regarding the spinbox, as per http://www.tkdocs.com/tutorial/morewidgets.html#spinbox, the ttk version appeared in Tk 8.5.9, which might explain it's absence in tkinter. A wrapper isn't too hard to do of course... e.g.

[issue27755] Retire DynOptionMenu with a ttk Combobox

Terry J. Reedy added the comment: Yes, if nothing else, we can use ttk.OptionMenu. #24776 is about the font tab specifically, including possibly using a spinbox for font size. #24781 is about Highlights tab. Whatever we do with theme selection we will probably copy for keyset selection.

[issue27755] Retire DynOptionMenu with a ttk Combobox

Cheryl Sabella added the comment: FYI, I believe that the ttk.OptionMenu is essentially the same as the DynOptionMenu. ttk.OptionMenu added a `set_menu` which is the same code as DynOptionMenu.SetMenu, except the options are radiobuttons (which marks the current item.) The only difference

[issue27755] Retire DynOptionMenu with a ttk Combobox

Justin Foo added the comment: Thanks for analysing further, Terry. My original goal was a drop-in replacement for an aspect of IDLE I found quite annoying (on Windows). Unfortunately, my limited playing with tkinter didn't inspire me to go beyond this. --

[issue27755] Retire DynOptionMenu with a ttk Combobox

Terry J. Reedy added the comment: I did more experiments with DOM (DynamicOptionMenu) and Combobox (CB). This was partly to evaluate CB as replacement for DOM for font size; partly to consider CB for the font list. At least by default, both start closed. Font list should start open. CB

[issue27755] Retire DynOptionMenu with a ttk Combobox

Terry J. Reedy added the comment: I did some experiments that cleared up some previous puzzlements about seemingly inconsistent behavior between interactive commands and those in scripts. The following prints '.mycombo' twice, on two lines, after selecting 'beta'. import tkinter as tk from

[issue27755] Retire DynOptionMenu with a ttk Combobox

Terry J. Reedy added the comment: Your ping got me to look at the doc for tk_optionMenu, which is a function rather than a widget (http://www.tcl.tk/man/tcl8.6/TkCmd/optionMenu.htm), the code for tkinter.OptionMenu (the only accurate doc I know of), which is a widget with the function API,

[issue27755] Retire DynOptionMenu with a ttk Combobox

Terry J. Reedy added the comment: I have not been working on IDLE for the last month, but may get back to it. Patched like this can go in any release, not just .0 version releases. (See PEP 434 for why.) -- ___ Python tracker

[issue27755] Retire DynOptionMenu with a ttk Combobox

Justin Foo added the comment: Is #24781 likely to make it into Python 3.6? Otherwise, would this patch be of any benefit in the meantime? -- ___ Python tracker

[issue27755] Retire DynOptionMenu with a ttk Combobox

Mark Roseman added the comment: Justin, as you say, I think your patch is entirely reasonable as an interim step, as eventually doing a broader improvement on the preferences dialog as suggested in #24781 makes sense. My reworked version used Combobox in similar ways; I think we can safely

[issue27755] Retire DynOptionMenu with a ttk Combobox

Justin Foo added the comment: I wasn't sure if the ongoing work in #24781 essentially rendered my patch obsolete, so I keenly await Mark's response. Upon reflection, I think my patch is a cheap win even if it's later overhauled by other improvements. -- status: closed -> open

[issue27755] Retire DynOptionMenu with a ttk Combobox

Terry J. Reedy added the comment: Justin, we are using ttk in 3.6, so the idea is feasible if it works. I do not remember a specific proposal to use ttk Combobox, as it could not be done before now. Mark, any comments? -- nosy: +markroseman ___

[issue27755] Retire DynOptionMenu with a ttk Combobox

Changes by SilentGhost : -- stage: -> resolved ___ Python tracker ___ ___

[issue27755] Retire DynOptionMenu with a ttk Combobox

Justin Foo added the comment: Ah, I've noticed the folly of my ways. This sort of stuff is already being managed with patches filed under various other issues. It just wasn't obvious to me as I wasn't seeing many new improvements in the default branch or much communication on IDLE-dev.

[issue27755] Retire DynOptionMenu with a ttk Combobox

Changes by Justin Foo : -- keywords: +patch Added file: http://bugs.python.org/file44097/issue27755.patch ___ Python tracker ___

[issue27755] Retire DynOptionMenu with a ttk Combobox

New submission from Justin Foo: One aspect of the IDLE interface that looks extremely old is the the dropdown menu. In the patch, I think I've preserved whatever essential functionality DynOptionMenu used to have, but I'm relatively unfamiliar with Tk so I'm not sure. -- assignee: