[issue27780] memory leaks in pgen build step abort build with address sanitizer enabled

Benjamin Peterson added the comment: New changeset 16137fe22f3f9bbbd50fac2a729172976c553718 by Benjamin Peterson (Zachary Ware) in branch '2.7': bpo-27780: Make pgen.c C89 compliant (GH-7915) https://github.com/python/cpython/commit/16137fe22f3f9bbbd50fac2a729172976c553718 --

[issue27780] memory leaks in pgen build step abort build with address sanitizer enabled

Change by Zachary Ware : -- pull_requests: +7518 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue27780] memory leaks in pgen build step abort build with address sanitizer enabled

Benjamin Peterson added the comment: New changeset 482fac74999028af4764645a1f28dd4289b2f255 by Benjamin Peterson in branch '2.7': [2.7] properly free memory in pgen. (GH-7869) (closes bpo-27780 https://github.com/python/cpython/commit/482fac74999028af4764645a1f28dd4289b2f255 --

[issue27780] memory leaks in pgen build step abort build with address sanitizer enabled

Change by Benjamin Peterson : -- keywords: +patch pull_requests: +7477 stage: needs patch -> patch review ___ Python tracker ___

[issue27780] memory leaks in pgen build step abort build with address sanitizer enabled

Ned Deily added the comment: Thanks, Zackery. @Benjamin, any opinion about a need for a 2.7 backport? Otherwise, it sounds like this can be closed. -- nosy: +benjamin.peterson ___ Python tracker

[issue27780] memory leaks in pgen build step abort build with address sanitizer enabled

Zackery Spytz added the comment: These memory leaks were fixed in commit 9ac11a752a19c3b8607582a3d5ccb615c467124b, though the fix wasn't applied to 2.7. -- nosy: +ZackerySpytz ___ Python tracker

[issue27780] memory leaks in pgen build step abort build with address sanitizer enabled

Xiang Zhang added the comment: Valgrind can also complain: valgrind --leak-check=yes --suppressions=Misc/valgrind-python.supp Parser/pgen ./Grammar/Grammar Include/graminit.h Python/graminit.c ==6836== Memcheck, a memory error detector ==6836== Copyright (C) 2002-2015, and GNU GPL'd, by Julian

[issue27780] memory leaks in pgen build step abort build with address sanitizer enabled

Ned Deily added the comment: OK, that's not unreasonable and I see there have been earlier issues opened and addressed for similar problems (e.g. Issue18695). Perhaps someone will want to dive in. -- resolution: wont fix -> stage: resolved -> needs patch status: closed -> open