[issue28000] Build fails on AIX with _LINUX_SOURCE_COMPAT flag

Changes by Matthieu S : -- resolution: -> fixed status: open -> closed ___ Python tracker ___

[issue28000] Build fails on AIX with _LINUX_SOURCE_COMPAT flag

Matthieu S added the comment: Thanks ! -- resolution: fixed -> status: closed -> open versions: -Python 3.7 ___ Python tracker ___

[issue28000] Build fails on AIX with _LINUX_SOURCE_COMPAT flag

Changes by Matthieu S : -- versions: +Python 3.7 ___ Python tracker ___

[issue28000] Build fails on AIX with _LINUX_SOURCE_COMPAT flag

Martin Panter added the comment: I committed your patches for 3.5+ and 2.7. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.7 ___ Python tracker

[issue28000] Build fails on AIX with _LINUX_SOURCE_COMPAT flag

Roundup Robot added the comment: New changeset 7598e65a924e by Martin Panter in branch '3.5': Issue #28000: Fix gethostbyname_r() usage on AIX with _LINUX_SOURCE_COMPAT https://hg.python.org/cpython/rev/7598e65a924e New changeset 77cb8fa47138 by Martin Panter in branch '2.7': Issue #28000: Fix

[issue28000] Build fails on AIX with _LINUX_SOURCE_COMPAT flag

Matthieu S added the comment: Sorry for the very late reply... Using _LINUX_SOURCE_COMPAT is sometimes preferable, as it greatly improves compatibility with code intended for Linux and improves XPG specs compliance. But I am not sure it should always be enabled. In our case, we use it as

[issue28000] Build fails on AIX with _LINUX_SOURCE_COMPAT flag

Martin Panter added the comment: Also, there is code in configure.ac to detect 3- and 6-arg versions. Perhaps can we use that in all cases for AIX (as for Linux)? The configure logic was overridden a long time ago: revision dad14ffe1c22. But I don’t know exactly why. -- versions:

[issue28000] Build fails on AIX with _LINUX_SOURCE_COMPAT flag

Martin Panter added the comment: Would it be appropriate to always build with _LINUX_SOURCE_COMPAT enabled or disabled? Or is there a disadvantage (e.g. compatibility with different AIX versions, or less functionality?) Do you know if this would also be applicable to 2.7? -- nosy:

[issue28000] Build fails on AIX with _LINUX_SOURCE_COMPAT flag

Changes by Eric N. Vander Weele : -- nosy: +ericvw ___ Python tracker ___ ___

[issue28000] Build fails on AIX with _LINUX_SOURCE_COMPAT flag

New submission from Matthieu S: Python build fails on AIX when using the _LINUX_SOURCE_COMPAT flag. When using this flag, the gethostbyname_r subroutine has 6 parameters instead of 3, like on Linux, but Modules/socketmodule.c always expects a gethostbyname_r subroutine with only 3 parameters