[issue28046] Remove the concept of platform-specific directories

STINNER Victor added the comment: Fixed. I close again the issue. I don't want to backport this change, it doesn't hurt Python 3.6. -- resolution: -> fixed status: open -> closed ___ Python tracker

[issue28046] Remove the concept of platform-specific directories

STINNER Victor added the comment: New changeset 5de15f1d5ff09085620f63f0597d0920d75be719 by Victor Stinner in branch 'master': bpo-28046: Remove MACHDEPPATH from Modules/Setup.dist (#5289) https://github.com/python/cpython/commit/5de15f1d5ff09085620f63f0597d0920d75be719 -- _

[issue28046] Remove the concept of platform-specific directories

STINNER Victor added the comment: The cleanup is not complete, so I reopen the issue: https://github.com/python/cpython/pull/5289 -- resolution: fixed -> status: closed -> open ___ Python tracker __

[issue28046] Remove the concept of platform-specific directories

Change by STINNER Victor : -- pull_requests: +5135 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue28046] Remove the concept of platform-specific directories

Change by Zachary Ware : -- resolution: -> fixed stage: commit review -> resolved status: pending -> closed ___ Python tracker ___ _

[issue28046] Remove the concept of platform-specific directories

Zachary Ware added the comment: Are there any remaining outstanding issues here? -- assignee: zach.ware -> status: open -> pending ___ Python tracker ___ _

[issue28046] Remove the concept of platform-specific directories

Roundup Robot added the comment: New changeset 86577b7100a4 by Xavier de Gaye in branch '3.6': Issue #28046: Fix the removal of the sysconfigdata module https://hg.python.org/cpython/rev/86577b7100a4 New changeset 28205c4cf20b by Xavier de Gaye in branch 'default': Issue #28046: Merge with 3.6.

[issue28046] Remove the concept of platform-specific directories

Xavier de Gaye added the comment: 'make install' fails to remove the sysconfigdata module from lib-dynload and prints now instead: rm: cannot remove '/path/to/install/lib/python3.7/lib-dynload/_sysconfigdata_m.py': No such file or directory The patch fixes this. It also removes a useless

[issue28046] Remove the concept of platform-specific directories

Matthias Klose added the comment: I don't like the _PYTHON_SYSCONFIGDATA_NAME hack. This should be based on the target, not on a name for just a particular file. Following up on that in #28125. -- ___ Python tracker

[issue28046] Remove the concept of platform-specific directories

Chi Hsuan Yen added the comment: No No, it's me who should say thank you. Thanks for all efforts on maintaining the Android port of CPython! -- ___ Python tracker ___ __

[issue28046] Remove the concept of platform-specific directories

Xavier de Gaye added the comment: Thanks for your help in testing these changes Chi Hsuan Yen. -- ___ Python tracker ___ ___ Python-bu

[issue28046] Remove the concept of platform-specific directories

Roundup Robot added the comment: New changeset 04b679dd11eb by Xavier de Gaye in branch 'default': Issue #28046: get_sysconfigdata_name() uses the _PYTHON_SYSCONFIGDATA_NAME https://hg.python.org/cpython/rev/04b679dd11eb -- ___ Python tracker

[issue28046] Remove the concept of platform-specific directories

Xavier de Gaye added the comment: One of the test_sysconfig failed test is caused by the changes made in issue 27917. I will fix it there. The other one is caused by a change in my android build setup that does not install anymore include/python3.6m/pyconfig.h, this is fixed now and the test d

[issue28046] Remove the concept of platform-specific directories

Chi Hsuan Yen added the comment: Much thanks! It's now building fine and running fine with my configuration. The test suite is still running and I believe there won't be more surprise than failed tests. -- ___ Python tracker

[issue28046] Remove the concept of platform-specific directories

Zachary Ware added the comment: LGTM, thank you Xavier! -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http

[issue28046] Remove the concept of platform-specific directories

Xavier de Gaye added the comment: With the attached patch, the python test suite runs smoothly on android and without errors on linux. On android, there are two new failed test cases in test_sysconfig that I will look into later (in the frame of this issue, I guess ?), but otherwise about the

[issue28046] Remove the concept of platform-specific directories

Chi Hsuan Yen added the comment: Hmm things are quite complicated. Brief: the build is broken for out-of-source cross-compiling if the host Python is an in-source build. (Below $build_dir refers to the directory that invokes $source_dir/configure) In an out-of-source build, setup.py relies on

[issue28046] Remove the concept of platform-specific directories

Chi Hsuan Yen added the comment: With this patch no extensions in Modules/ can be built. Let me check whether there's a bug in my build script. -- ___ Python tracker ___ ___

[issue28046] Remove the concept of platform-specific directories

Roundup Robot added the comment: New changeset 1d71ce4531ac by Xavier de Gaye in branch 'default': Issue #28046: Fix get_sysconfigdata_name(). https://hg.python.org/cpython/rev/1d71ce4531ac -- ___ Python tracker __

[issue28046] Remove the concept of platform-specific directories

Zachary Ware added the comment: Xavier, that change looks good to me, please commit it. -- ___ Python tracker ___ ___ Python-bugs-list

[issue28046] Remove the concept of platform-specific directories

Xavier de Gaye added the comment: Confirming the problem reported by Chi Hsuan Yen. The attached patch fixes this. Another problem is that the shared libraries names of the extension modules are now suffixed with the wrong triplet, i.e. with the build system triplet instead of the target host

[issue28046] Remove the concept of platform-specific directories

Chi Hsuan Yen added the comment: Got it. When calling `python -m sysconfig --generate-posix-vars`, the host (Linux x86_64) Python is used, so _get_sysconfigdata_name() returns the name for Linux instead of for Android. Maybe _get_sysconfigdata_name() should check whether it's used for cross-co

[issue28046] Remove the concept of platform-specific directories

Chi Hsuan Yen added the comment: Seems after this changeset Python is broken: shell@ASUS_Z00E_2:/data/local/tmp/python3 $ python3.6 Failed to import the site module Traceback (most recent call last): File "/data/local/tmp/python3/lib/python3.6/site.py", line 549, in main() File "/data/l

[issue28046] Remove the concept of platform-specific directories

Roundup Robot added the comment: New changeset 2bfe63a3eb5c by Zachary Ware in branch 'default': Issue #28046: Fix distutils https://hg.python.org/cpython/rev/2bfe63a3eb5c -- ___ Python tracker

[issue28046] Remove the concept of platform-specific directories

Zachary Ware added the comment: Xavier: I'm still interested in hearing whether this breaks anything for you, but I went ahead and pushed it. -- ___ Python tracker ___ _

[issue28046] Remove the concept of platform-specific directories

Roundup Robot added the comment: New changeset 90396ec9a2f8 by Zachary Ware in branch 'default': Issue #28046: Remove platform-specific directories from sys.path https://hg.python.org/cpython/rev/90396ec9a2f8 -- nosy: +python-dev ___ Python tracker <

[issue28046] Remove the concept of platform-specific directories

Xavier de Gaye added the comment: Sure, I was already planning to do it :) -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue28046] Remove the concept of platform-specific directories

Zachary Ware added the comment: Xavier: Could you please make sure this doesn't break anything for Android/cross-builds? -- ___ Python tracker ___ __

[issue28046] Remove the concept of platform-specific directories

STINNER Victor added the comment: Matthias Klose added the comment: > The removal is not following the guidelines to first deprecate these for a > release, and then to remove them. I know that at least the RTLD_* constants > are used in a number of places, which will just stop working. Please

[issue28046] Remove the concept of platform-specific directories

Matthias Klose added the comment: The removal is not following the guidelines to first deprecate these for a release, and then to remove them. I know that at least the RTLD_* constants are used in a number of places, which will just stop working. I'm not against removing these in 3.7, however

[issue28046] Remove the concept of platform-specific directories

STINNER Victor added the comment: > this comes as a surprise. I can't remember that discussion and decision. Removing these modules is not a new idea: I just posted a message to the issue #28027 to complete the history of this change. -- ___ Python

[issue28046] Remove the concept of platform-specific directories

Zachary Ware added the comment: Sorry, it happened at the sprint at Instagram. Do you have a use for those modules that we need to reconsider? -- ___ Python tracker ___ ___

[issue28046] Remove the concept of platform-specific directories

Matthias Klose added the comment: this comes as a surprise. I can't remember that discussion and decision. -- ___ Python tracker ___ _

[issue28046] Remove the concept of platform-specific directories

Zachary Ware added the comment: Those were removed in #28027, by BDFL decree. -- ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue28046] Remove the concept of platform-specific directories

Matthias Klose added the comment: not sure if I fully understand: - The patch encodes the multiarch triplet into the _sysconfigdata name and installs it into the standard lib dir. - It removes the PLATDIR macro - what happens to the constants modules which are currently found in the pla

[issue28046] Remove the concept of platform-specific directories

STINNER Victor added the comment: You might also remove Lib/_sysconfigdata.py from .gitignore. -- nosy: +haypo ___ Python tracker ___ ___

[issue28046] Remove the concept of platform-specific directories

New submission from Zachary Ware: As a follow-on to #28027, the attached patch removes the concept of platform-specific directories (Lib/plat-darwin, Lib/plat-x86_64-linux-gnu, etc). I believe this should be fine for cross-builds (at least as fine as the previous solution for _sysconfigdata),