[issue28119] Explicit null dereferenced in formatter_unicode.c

2016-09-14 Thread Christian Heimes
Christian Heimes added the comment: Thanks! You fixed the problem and Coverity is no longer complaining. The code is more readable, too. Are you talking about these lines? Yes, they were confusing me. if (locale_info->thousands_sep == NULL) { Py_DECREF(locale_info->decimal_point); } -

[issue28119] Explicit null dereferenced in formatter_unicode.c

2016-09-13 Thread Benjamin Peterson
Benjamin Peterson added the comment: I think that should take care of it (and also possible double-frees I noticed)? -- nosy: +benjamin.peterson ___ Python tracker ___ __

[issue28119] Explicit null dereferenced in formatter_unicode.c

2016-09-13 Thread Roundup Robot
Roundup Robot added the comment: New changeset a27cb132e140 by Benjamin Peterson in branch '3.5': improve type-safe of and prevent double-frees in get_locale_info (#28119) https://hg.python.org/cpython/rev/a27cb132e140 New changeset 5ab61df1ca96 by Benjamin Peterson in branch '3.6': merge 3.5 (#

[issue28119] Explicit null dereferenced in formatter_unicode.c

2016-09-13 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- nosy: +haypo, serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue28119] Explicit null dereferenced in formatter_unicode.c

2016-09-13 Thread Christian Heimes
New submission from Christian Heimes: Coverity is warning about four cases of potential NULL forwarding in which subsequent code does not expect a NULL value. 30. no_write_call: Although get_locale_info does overwrite locale.decimal_point on some paths, it also contains at least one feasible p