[issue28143] ASDL compatibility with Python 3 system interpreter

2020-01-10 Thread Cheryl Sabella
Change by Cheryl Sabella : -- resolution: -> wont fix stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue28143] ASDL compatibility with Python 3 system interpreter

2017-10-23 Thread Malthe Borch
Change by Malthe Borch : -- pull_requests: +4052 stage: needs patch -> patch review ___ Python tracker ___

[issue28143] ASDL compatibility with Python 3 system interpreter

2017-10-23 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Do you mind to create a pull request on GitHub Malthe? -- stage: -> needs patch ___ Python tracker

[issue28143] ASDL compatibility with Python 3 system interpreter

2016-10-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: print in Python 2 doesn't add a space after whitespace characters except a space ('\t', '\n', '\r', etc). -- nosy: +serhiy.storchaka ___ Python tracker

[issue28143] ASDL compatibility with Python 3 system interpreter

2016-10-15 Thread Malthe Borch
Malthe Borch added the comment: You're right. The trailing comma just suppresses the newline. I updated the patch. -- Added file: http://bugs.python.org/file45105/0001-Allow-make-to-be-run-under-Python-3.patch ___ Python tracker

[issue28143] ASDL compatibility with Python 3 system interpreter

2016-10-15 Thread Martin Panter
Martin Panter added the comment: Are you sure about adding the space after tab? I am no Python 2 expert, but I don’t see it: $ python2 -c 'print "\t", ""' | cat -A ^I$ Anyway, I’m not happy applying this patch unless it is clear that raising the Python version required to rebuild ASDL stuff

[issue28143] ASDL compatibility with Python 3 system interpreter

2016-09-24 Thread Malthe Borch
Malthe Borch added the comment: I have updated the patch with requested changes. Note that the original code also added space after '\t' characters. I have not changed this on purpose. -- Added file: http://bugs.python.org/file44801/0001-Allow-make-to-be-run-under-Python-3.patch

[issue28143] ASDL compatibility with Python 3 system interpreter

2016-09-23 Thread Martin Panter
Martin Panter added the comment: That would get the patch mostly working with 2.6+. Is it okay to break Python < 2.6 support? I know there was an OS X Tiger buildbot using 2.5 until recently; see Issue 28039. Personally, I would rather focus on the problems with make dependencies, build

[issue28143] ASDL compatibility with Python 3 system interpreter

2016-09-18 Thread Malthe Borch
Malthe Borch added the comment: I forgot to add "from __future__ import print_function" to the beginning of "asdl.py" and "spark.py". It should then work on Python 2. That is, with the imported print-function, the incompatibilities that Martin pointed out are no longer there. As for Windows,

[issue28143] ASDL compatibility with Python 3 system interpreter

2016-09-17 Thread Martin Panter
Martin Panter added the comment: This patch ports the logic written for Issue 26662 to Python 2. Basically, configure searches for commands called python2.7, python2, and python (in order of priority), and sets PYTHON_FOR_GEN to the result. PYTHON_FOR_GEN could be overridden by the user if

[issue28143] ASDL compatibility with Python 3 system interpreter

2016-09-16 Thread R. David Murray
R. David Murray added the comment: If we go that route it doesn't, from a certain point of view, solve the problem for systems that *only* ship python3...but I think we can ignore that issue: IMO it would be fine in that scenario to say that if you want to run the python2 regen scripts you

[issue28143] ASDL compatibility with Python 3 system interpreter

2016-09-15 Thread Martin Panter
Martin Panter added the comment: Another option I forgot to point out is that some of the other regeneration Python scripts (in Py 2 and/or 3; I forget which) have some autoconf magic to figure out the right installed python command to use. We should probably use that for Py 2’s ASDL script.

[issue28143] ASDL compatibility with Python 3 system interpreter

2016-09-15 Thread R. David Murray
R. David Murray added the comment: Yes, by "fix this" I meant make it work under both python2 and python3. But failing that, the status quo wins. -- ___ Python tracker

[issue28143] ASDL compatibility with Python 3 system interpreter

2016-09-15 Thread Martin Panter
Martin Panter added the comment: It seems a terrible idea to require Python 3 to be installed in order to regenerate the boot files for a Python 2 build. Maybe if we can figure out the minimum installed Python version expected for these ASDL scripts in 2.7, and maintain that while adding

[issue28143] ASDL compatibility with Python 3 system interpreter

2016-09-14 Thread R. David Murray
R. David Murray added the comment: It's probably not a bad thing to fix this, but you should be able to avoid the problem by using 'make touch' before building. It should not be necessary to have a running python to build python; all the build artifacts are checked in. Specifically, the

[issue28143] ASDL compatibility with Python 3 system interpreter

2016-09-14 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- nosy: +benjamin.peterson ___ Python tracker ___

[issue28143] ASDL compatibility with Python 3 system interpreter

2016-09-14 Thread Malthe Borch
New submission from Malthe Borch: Many systems today use Python 3 as the default interpreter "python". The Python 2.7 build fails because of syntax incompatibility. Attached patch fixes this. -- components: Build files: 0001-Allow-make-to-be-run-under-Python-3.patch keywords: patch