[issue28145] Fix whitespace in C source code

Francisco Couzo added the comment: I'm closing this issue since I've created new issues for each case, please refer to #28184, #28185, and #28186. -- status: open -> closed ___ Python tracker

[issue28145] Fix whitespace in C source code

Serhiy Storchaka added the comment: See also issue15550 and issue8912. -- nosy: +serhiy.storchaka ___ Python tracker ___

[issue28145] Fix whitespace in C source code

Terry J. Reedy added the comment: Converting tabs to spaces and deleting trailing whitespace are separate issues and should be discussed and possibly done separately. I think trailing whitespace should be uniformly fixed and prohibited for C files as it seems to be for most other files, for

[issue28145] Fix whitespace in C source code

Roundup Robot added the comment: New changeset 2a97b5ab6132 by Martin Panter in branch '2.7': Issue #28145: Spelling fixes https://hg.python.org/cpython/rev/2a97b5ab6132 New changeset 02dd99aeba7d by Martin Panter in branch '3.5': Issue #28145: Spelling fixes

[issue28145] Fix whitespace in C source code

R. David Murray added the comment: A while ago Antoine fixed the leading tabs throughout the C source, after considerable debate about it. So we've been down this road before. Since I don't touch the C code often, I don't really have an opinion on this one way or the other :) --

[issue28145] Fix whitespace in C source code

Mark Dickinson added the comment: It's also worth noting that "make patchcheck", which we're encouraged to use by the Python developer's guide, autofixes these whitespace issues. I find that somewhat annoying, since "make patchcheck" makes changes unrelated to the patch I'm committing, which

[issue28145] Fix whitespace in C source code

Josh Rosenberg added the comment: Well, it's trading one person's style for the PEP7 official style, so it's not completely arbitrary. That said, I'm not sure it's justifiable to apply to the entire historic code base; my impression was that PEP7 was not intended to be applied retroactively

[issue28145] Fix whitespace in C source code

Martin Panter added the comment: What is the reasoning behind this? It seems like trading one person’s style, fashion, or editor settings for another. I think it is better to just tolerate existing styles, unless they cause significant problems. But maybe see what other people think. The

[issue28145] Fix whitespace in C source code

New submission from Francisco Couzo: I changed most of the tabs in the source code to spaces, and removed trailing whitespace. I also made some scripts that generate code use spaces and not generate trailing whitespace. (makesetup and makeunicodedata.py) I fixed a typo in Modules/makesetup