[issue28180] Implementation of the PEP 538: coerce C locale to C.utf-8

Matej Cepl added the comment: Thank you very much for the hint. Do I have to include the patch for bpo-19977 only (that would be easy), or also all twelve PRs for bpo-29240 (that would probably broke my will to do it)? -- ___ Python tracker

[issue28180] Implementation of the PEP 538: coerce C locale to C.utf-8

Nick Coghlan added the comment: The test cases for locale coercion *not* triggering still assume that bpo-19977, using surrogateescape on the standard streams in the POSIX locale, has been implemented (since that was implemented in Python 3.5). Hence the various test cases complaining that

[issue28180] Implementation of the PEP 538: coerce C locale to C.utf-8

STINNER Victor added the comment: RHEL 7.7 and RHEL 8 provides Python 3.6. PEP 538 was implemented in Python 3.7. PEP 538 feature was backported in RHEL 7.7 and RHEL 8 Python 3.6. -- ___ Python tracker

[issue28180] Implementation of the PEP 538: coerce C locale to C.utf-8

Matej Cepl added the comment: > Python 3.4 is no longer supported upstream. Python 3 got tons of Unicode > fixes between Python 3.4 and Python 3.8. Of course, I know that, but I just didn’t want to throw all my effort away, when I spent some hours on making it. And I guess, there may be

[issue28180] Implementation of the PEP 538: coerce C locale to C.utf-8

STINNER Victor added the comment: Python 3.4 is no longer supported upstream. Python 3 got tons of Unicode fixes between Python 3.4 and Python 3.8. -- ___ Python tracker ___

[issue28180] Implementation of the PEP 538: coerce C locale to C.utf-8

Matej Cepl added the comment: I have tried to port this patch to Python 3.4 (still maintained by SUSE on SLE-12), but I have the hardest time to debug this. All affected tests end with errors like this: [ 493s] == [ 493s]

[issue28180] Implementation of the PEP 538: coerce C locale to C.utf-8

Nick Coghlan added the comment: Given that issue 32002 and issue 30672 track the known challenges in testing the expected locale coercion behaviour reliably, I'm going to go ahead and close this overall implementation issue (the feature is there, and works in a way we're

[issue28180] Implementation of the PEP 538: coerce C locale to C.utf-8

Xavier de Gaye added the comment: New changeset 1588be66d7b0eeebc4614309cd0fc837ff52776a by xdegaye in branch 'master': bpo-28180: Fix the implementation of PEP 538 on Android (GH-4334) https://github.com/python/cpython/commit/1588be66d7b0eeebc4614309cd0fc837ff52776a

[issue28180] Implementation of the PEP 538: coerce C locale to C.utf-8

Xavier de Gaye added the comment: PR 4334 added: fix the implementation of PEP 538 on Android. The current implementation of PEP 538 fixes issue 28997 without the locale coercion for Android added by PR 4334, see msg305848. --

[issue28180] Implementation of the PEP 538: coerce C locale to C.utf-8

Change by Xavier de Gaye : -- pull_requests: +4289 stage: -> patch review ___ Python tracker ___

[issue28180] Implementation of the PEP 538: coerce C locale to C.utf-8

Nick Coghlan added the comment: The latest commit should get the Mac OS X buildbot back to green, but I had to disable some test cases to do it - see issue 30672 for details. Issue 30565 is the one that covers silencing the locale coercion and locale compatibility warnings by default.

[issue28180] Implementation of the PEP 538: coerce C locale to C.utf-8

Nick Coghlan added the comment: New changeset 7926516ff95ed9c8345ed4c4c4910f44ffbd5949 by Nick Coghlan in branch 'master': bpo-28180: Standard stream & FS encoding differ on Mac OS X (GH-2208) https://github.com/python/cpython/commit/7926516ff95ed9c8345ed4c4c4910f44ffbd5949 --

[issue28180] Implementation of the PEP 538: coerce C locale to C.utf-8

Changes by Nick Coghlan : -- pull_requests: +2252 ___ Python tracker ___ ___

[issue28180] Implementation of the PEP 538: coerce C locale to C.utf-8

Nick Coghlan added the comment: Ah, I finally understand Victor's comment on my initial attempt at fixing the tests on Mac OS X - the standard streams *don't* use the filesystem encoding, so they default to ASCII in the C locale, even on Mac OS X. --

[issue28180] Implementation of the PEP 538: coerce C locale to C.utf-8

Nick Coghlan added the comment: I've added dependencies for PEP 538 induced testing problems that have been broken out into their own issues. I've also merged my attempt at fixing the tests on Mac OS X. Something that's included in that patch is an implicit skip of the "LANG=UTF-8" case when

[issue28180] Implementation of the PEP 538: coerce C locale to C.utf-8

Nick Coghlan added the comment: New changeset 4563099d28e832aed22b85ce7e2a92236df03847 by Nick Coghlan in branch 'master': bpo-28180: assume UTF-8 for Mac OS X PEP 538 tests (GH-2130) https://github.com/python/cpython/commit/4563099d28e832aed22b85ce7e2a92236df03847 --

[issue28180] Implementation of the PEP 538: coerce C locale to C.utf-8

STINNER Victor added the comment: New changeset eb52ac89929bb09b15c014ab8ff60eee685e86c7 by Victor Stinner in branch 'master': bpo-28180: Fix test_capi.test_forced_io_encoding() (#2155) https://github.com/python/cpython/commit/eb52ac89929bb09b15c014ab8ff60eee685e86c7 --

[issue28180] Implementation of the PEP 538: coerce C locale to C.utf-8

Changes by STINNER Victor : -- pull_requests: +2205 ___ Python tracker ___ ___

[issue28180] Implementation of the PEP 538: coerce C locale to C.utf-8

Changes by STINNER Victor : -- title: sys.getfilesystemencoding() should default to utf-8 -> Implementation of the PEP 538: coerce C locale to C.utf-8 ___ Python tracker