[issue28256] Cleanup Modules/_math.c

2016-10-18 Thread STINNER Victor
STINNER Victor added the comment: Thanks for the review Serhiy and Christian, it seems like a review was needed :-D I pushed my fix to Python 3.7. -- resolution: -> fixed status: open -> closed ___ Python tracker

[issue28256] Cleanup Modules/_math.c

2016-10-18 Thread Roundup Robot
Roundup Robot added the comment: New changeset 8999d702ac29 by Victor Stinner in branch 'default': Issue #28256: Cleanup _math.c https://hg.python.org/cpython/rev/8999d702ac29 -- nosy: +python-dev ___ Python tracker

[issue28256] Cleanup Modules/_math.c

2016-09-23 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:

[issue28256] Cleanup Modules/_math.c

2016-09-23 Thread Christian Heimes
Christian Heimes added the comment: It think you have the #ifdef checks reversed, e.g. #ifdef HAVE_ACOSH instead of #ifndef HAVE_ACOSH. -- ___ Python tracker ___ ___

[issue28256] Cleanup Modules/_math.c

2016-09-23 Thread STINNER Victor
New submission from STINNER Victor: On a code coverage report, I noticed that _math.c has a very bad coverage. In fact, we define dead code when the system provides most required math functions. Attached patch avoids declaring unused functions. See the coverage at: http://tiran.bitbucket.org/p