[issue28281] Remove year limits from calendar

2017-10-26 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: New changeset 66c88ce30ca2b23daa37038e1a3c0de98f241f50 by Alexander Belopolsky in branch 'master': Closes bpo-28281: Remove year (1-) limits on the weekday() function. (#4109)

[issue28281] Remove year limits from calendar

2017-10-24 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: I submitted Mark's patch unchanged as PR 4109. If we don't hear from Mark, I will address my own comments and merge. -- ___ Python tracker

[issue28281] Remove year limits from calendar

2017-10-24 Thread Alexander Belopolsky
Change by Alexander Belopolsky : -- pull_requests: +4079 stage: commit review -> patch review ___ Python tracker ___

[issue28281] Remove year limits from calendar

2017-10-24 Thread Cheryl Sabella
Cheryl Sabella added the comment: Hello Mark, Would you be able to prepare a pull request on GitHub for your patch? Thanks! -- nosy: +csabella ___ Python tracker

[issue28281] Remove year limits from calendar

2016-10-22 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: The patch should include an update to documentation. 1. We should probably explain that python -mcalendar does not reproduce the output of UNIX cal. For example, on Mac OS (and various Linux variants): $ cal 9 1752 September 1752 Su Mo Tu We Th Fr

[issue28281] Remove year limits from calendar

2016-10-22 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Alexander as core developer and the creator of this issue can merge the patch after making his review. But first we should make a decision whether it is worth to do at all. I'm +0 now. Raymond seems has objections. --

[issue28281] Remove year limits from calendar

2016-10-21 Thread Stéphane Wirtel
Stéphane Wirtel added the comment: Who can merge this patch ? -- nosy: +matrixise ___ Python tracker ___ ___

[issue28281] Remove year limits from calendar

2016-10-21 Thread Stéphane Wirtel
Changes by Stéphane Wirtel : -- stage: needs patch -> commit review ___ Python tracker ___

[issue28281] Remove year limits from calendar

2016-10-01 Thread Mark Gollahon
Mark Gollahon added the comment: First time patch for CPython. I followed instructions given by belopolsky and added tests. Please critique. -- keywords: +patch nosy: +golly Added file: http://bugs.python.org/file44917/calendar-no-year-limits.patch

[issue28281] Remove year limits from calendar

2016-09-28 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Okay, if this is specified by ISO 8601 standard, I think we can extend calendar below year 1. But the meaning of non-positive years should be documented. And maybe even provide a way to customize the representation of year (this is a separate issue).

[issue28281] Remove year limits from calendar

2016-09-28 Thread Mariatta Wijaya
Changes by Mariatta Wijaya : -- nosy: +Mariatta ___ Python tracker ___ ___

[issue28281] Remove year limits from calendar

2016-09-28 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: The proposed interpretation of nonpositive years is not arbitrary, it is a natural extension of the same formulas that we use for positive years. On the other hand 1- limits are arbitrary. If we wanted to restrict calendars to 4-digit years we

[issue28281] Remove year limits from calendar

2016-09-28 Thread Raymond Hettinger
Raymond Hettinger added the comment: > Under my proposal year=-1 is 2 B.C. and year 0 is a leap year We should refuse the temptation to guess (i.e. make up our own arbitrary interpretations). Instead, just document the known limits. -- nosy: +rhettinger

[issue28281] Remove year limits from calendar

2016-09-27 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: Under my proposal year=-1 is 2 B.C. and year 0 is a leap year $ ./python.exe -mcalendar 0 2 February 0 Mo Tu We Th Fr Sa Su 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 This is the simplest extension and

[issue28281] Remove year limits from calendar

2016-09-27 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I think data range is limited by year 1 due to ambiguity of year -1. Is it 1 B.D. or 2 years before year 1 (2 B.D.)? -- ___ Python tracker

[issue28281] Remove year limits from calendar

2016-09-27 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: > What's the use case for this? Why did George Mallory climb Mount Everest? "Because it's there." We have two open issues complaining about calendar behavior for years 1 and : #28253 and #26650. There is also a closed issue #15421 that attempted to

[issue28281] Remove year limits from calendar

2016-09-27 Thread Walter Dörwald
Walter Dörwald added the comment: I don't think that's necessary. What's the use case for this? And if we want to to this, wouldn't it be better to enhance datetime, so that this use case is supported too? -- ___ Python tracker

[issue28281] Remove year limits from calendar

2016-09-26 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- nosy: +doerwalter ___ Python tracker ___ ___

[issue28281] Remove year limits from calendar

2016-09-26 Thread Alexander Belopolsky
New submission from Alexander Belopolsky: The calendar module currently relies on datetime for some calculations and is therefore restricted to years 1 through . With exception to some public methods that are documented to return datetime.date instances, this dependence on the datetime