[issue28294] HTTPServer server.py assumes sys.stderr != None

2016-10-02 Thread Jaap van der Velde
Jaap van der Velde added the comment: Breaking the API isn't good, but it will only break if log_message doesn't *receive* all messages, because that's what people who override it count on. If there's some way of detecting who called log_message, you could use the appropriate log level on

[issue28294] HTTPServer server.py assumes sys.stderr != None

2016-10-01 Thread R. David Murray
R. David Murray added the comment: OK, lets close this won't fix, then. Especially since aiohttp does use logging already Sorry, Mariatta. Thanks for the patch, but we aren't going to use it. -- resolution: -> wont fix stage: -> resolved status: open -> closed

[issue28294] HTTPServer server.py assumes sys.stderr != None

2016-10-01 Thread Guido van Rossum
Guido van Rossum added the comment: A problem with switching to logging is the API design. There are three functions, log_request(), log_error() and log_message(). The former two call the latter. The API explicitly encourages overriding log_message() to customize logging. But it has no way to

[issue28294] HTTPServer server.py assumes sys.stderr != None

2016-10-01 Thread Jaap van der Velde
Jaap van der Velde added the comment: Closing and not fixing is fair enough - I did not realize that this would be an issue that occurs in many places in stdlib. I realize this is not a help forum, so I will ask elsewhere to see if there's some way to redirect all of sys.stderr in scenarios

[issue28294] HTTPServer server.py assumes sys.stderr != None

2016-10-01 Thread R. David Murray
R. David Murray added the comment: That would be my answer if we aren't switching to logging. I would consider that an enhancement, but are there reasons to not do that? -- ___ Python tracker

[issue28294] HTTPServer server.py assumes sys.stderr != None

2016-09-30 Thread Guido van Rossum
Guido van Rossum added the comment: I wonder if we shouldn't close this as "won't fix" and tell the OP to override the log_message() method. It's kind of curious to complain about *this* dependency on sys.stderr existing and working, since there are probably 1000s of other places in the

[issue28294] HTTPServer server.py assumes sys.stderr != None

2016-09-29 Thread Mariatta Wijaya
Mariatta Wijaya added the comment: use the logging module instead of sys.stderr -- keywords: +patch Added file: http://bugs.python.org/file44890/issue28294.patch ___ Python tracker

[issue28294] HTTPServer server.py assumes sys.stderr != None

2016-09-29 Thread Mariatta Wijaya
Mariatta Wijaya added the comment: I'm interested to work on a patch for this, if no one started yet. -- ___ Python tracker ___

[issue28294] HTTPServer server.py assumes sys.stderr != None

2016-09-29 Thread Senthil Kumaran
Senthil Kumaran added the comment: Using logging, instead of sys.stderr would be a welcome change in this module. -- keywords: +easy, needs review nosy: +orsenthil ___ Python tracker

[issue28294] HTTPServer server.py assumes sys.stderr != None

2016-09-28 Thread Mariatta Wijaya
Changes by Mariatta Wijaya : -- nosy: +Mariatta ___ Python tracker ___ ___

[issue28294] HTTPServer server.py assumes sys.stderr != None

2016-09-28 Thread R. David Murray
R. David Murray added the comment: That would be masking an error, I think. What might be reasonable would be to convert it to use the logging module in 3.7. -- nosy: +r.david.murray ___ Python tracker

[issue28294] HTTPServer server.py assumes sys.stderr != None

2016-09-28 Thread Jaap van der Velde
New submission from Jaap van der Velde: On line 556 of server.py, the sys.stderr.write assumes that sys.stderr is assigned and not None. However, when developing Windows services using the pypiwin32 library (as an example), sys.stderr == None A workaround is to override the log_message