[issue28298] can't set big int-like objects to items in array 'Q', 'L' and 'I'

Serhiy Storchaka added the comment: New changeset 964281af59d7a17d923c4d72357e48832b774e39 by Serhiy Storchaka (orenmn) in branch 'master': bpo-28298: make array 'Q', 'L' and 'I' accept big intables as elements (#570) https://github.com/python/cpython/commit/964281af59d7a17d923c4d72357e48832b77

[issue28298] can't set big int-like objects to items in array 'Q', 'L' and 'I'

Serhiy Storchaka added the comment: New changeset 26d013e00f9d4adbcf3e084bbc890c799ff70407 by Serhiy Storchaka (orenmn) in branch '3.6': [3.6] bpo-28298: make array 'Q', 'L' and 'I' accept big intables as elements (#579) https://github.com/python/cpython/commit/26d013e00f9d4adbcf3e084bbc890c79

[issue28298] can't set big int-like objects to items in array 'Q', 'L' and 'I'

Serhiy Storchaka added the comment: New changeset e2c88bdd6bb3efbc81389958d62daf6dd0d6eda7 by Serhiy Storchaka (orenmn) in branch '3.5': bpo-28298: make array 'Q', 'L' and 'I' accept big intables as elements https://github.com/python/cpython/commit/e2c88bdd6bb3efbc81389958d62daf6dd0d6eda7 ---

[issue28298] can't set big int-like objects to items in array 'Q', 'L' and 'I'

Changes by Larry Hastings : -- pull_requests: +604 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue28298] can't set big int-like objects to items in array 'Q', 'L' and 'I'

Oren Milman added the comment: Thanks for the reviews :) -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: htt

[issue28298] can't set big int-like objects to items in array 'Q', 'L' and 'I'

Serhiy Storchaka added the comment: Thank you for your contribution Oren. -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker ___

[issue28298] can't set big int-like objects to items in array 'Q', 'L' and 'I'

Changes by Oren Milman : -- pull_requests: +485 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue28298] can't set big int-like objects to items in array 'Q', 'L' and 'I'

Changes by Oren Milman : -- pull_requests: +476 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue28298] can't set big int-like objects to items in array 'Q', 'L' and 'I'

Changes by Oren Milman : -- pull_requests: +466 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue28298] can't set big int-like objects to items in array 'Q', 'L' and 'I'

Oren Milman added the comment: yes and yes. I would start with a PR for 3.7. and thanks for the review :) -- ___ Python tracker ___ _

[issue28298] can't set big int-like objects to items in array 'Q', 'L' and 'I'

Serhiy Storchaka added the comment: LGTM. But maybe combine PyFloat_Check+_PyLong_FromNbInt in one helper function? Could you please create a PR Oren? -- stage: patch review -> commit review versions: +Python 3.5, Python 3.6 ___ Python tracker

[issue28298] can't set big int-like objects to items in array 'Q', 'L' and 'I'

Changes by Serhiy Storchaka : -- stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:

[issue28298] can't set big int-like objects to items in array 'Q', 'L' and 'I'

Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue28298] can't set big int-like objects to items in array 'Q', 'L' and 'I'

Oren Milman added the comment: ping -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/

[issue28298] can't set big int-like objects to items in array 'Q', 'L' and 'I'

Oren Milman added the comment: Ah, I should have read more about __int__ and __index__ before writing my last reply. So IIUC, this is a somewhat painful issue, which could be resolved by: * #20092 * replacing _PyLong_FromNbInt with PyNumber_Index in: - Objects/longobject.c (as yo

[issue28298] can't set big int-like objects to items in array 'Q', 'L' and 'I'

Mark Dickinson added the comment: > and got a 'TypeError: an integer is required (got type LikeInt)' Right, see #12974 for more on arrays, `__int__` and `__index__`. -- ___ Python tracker _

[issue28298] can't set big int-like objects to items in array 'Q', 'L' and 'I'

Oren Milman added the comment: You are right about the terminology of course. My bad. Anyway, the bug is not related to __index__ (or nb_index), because the three aforementioned functions are using (in case '!PyLong_Check(v)') PyArg_Parse with the formats 'l' or 'L'. Ultimately, convertsimple

[issue28298] can't set big int-like objects to items in array 'Q', 'L' and 'I'

Mark Dickinson added the comment: One comment here: it's not the presence of `__int__` that makes a type integer-like; it's the presence of `__index__`. (Decimal and float both supply `__int__`, but shouldn't be regarded as integer-like, for example.) I'm guessing that we're going to have the

[issue28298] can't set big int-like objects to items in array 'Q', 'L' and 'I'

Changes by Serhiy Storchaka : -- nosy: +mark.dickinson, meador.inge ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue28298] can't set big int-like objects to items in array 'Q', 'L' and 'I'

Changes by Serhiy Storchaka : -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:

[issue28298] can't set big int-like objects to items in array 'Q', 'L' and 'I'

Changes by Oren Milman : -- versions: +Python 3.7 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue28298] can't set big int-like objects to items in array 'Q', 'L' and 'I'

Changes by Oren Milman : -- keywords: +patch Added file: http://bugs.python.org/file44862/issue28298_ver1.diff ___ Python tracker ___

[issue28298] can't set big int-like objects to items in array 'Q', 'L' and 'I'

Changes by Oren Milman : Added file: http://bugs.python.org/file44861/CPythonTestOutput.txt ___ Python tracker ___ ___ Python-bugs-list mailin

[issue28298] can't set big int-like objects to items in array 'Q', 'L' and 'I'

New submission from Oren Milman: current state On my Windows 10, on a 32-bit Python, The following runs fine: import array array.array('L').append(2 ** 32 - 1) However, in the following, an OverflowError('Python int too large to convert to C long') is raised on