[issue28353] os.fwalk() unhandled exception when error occurs accessing symbolic link target

Changes by Donald Stufft : -- pull_requests: +851 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue28353] os.fwalk() unhandled exception when error occurs accessing symbolic link target

Xiang Zhang added the comment: It works. Close. :-) -- status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue28353] os.fwalk() unhandled exception when error occurs accessing symbolic link target

Serhiy Storchaka added the comment: test_walk_bad_dir renamed one of subdirs and tearDown failed to clean up changed tree. An error happened depending on the order of listed subdirectories: ['SUB1', 'SUB2'] -- passed, ['SUB2', 'SUB1'] -- failed. --

[issue28353] os.fwalk() unhandled exception when error occurs accessing symbolic link target

Roundup Robot added the comment: New changeset 655510dd46fd by Serhiy Storchaka in branch '3.5': Issue #28353: Make test_os.WalkTests.test_walk_bad_dir stable. https://hg.python.org/cpython/rev/655510dd46fd New changeset df28e536f19d by Serhiy Storchaka in branch '3.6': Issue #28353: Make test_o

[issue28353] os.fwalk() unhandled exception when error occurs accessing symbolic link target

Xiang Zhang added the comment: Seems like the dir you add breaks other cases. I change addCleanUp to os.chmod and get: == FAIL: test_file_like_path (test.test_os.BytesWalkTests) -

[issue28353] os.fwalk() unhandled exception when error occurs accessing symbolic link target

Serhiy Storchaka added the comment: Hmm, tests were passed when I ran them before committing. Seems this is heisenbug. -- ___ Python tracker ___

[issue28353] os.fwalk() unhandled exception when error occurs accessing symbolic link target

Xiang Zhang added the comment: Serhiy, after your commits, test_os requires root privileges or it'll fail. This is not the case before. [cpython]$ ./python -m test test_os Run tests sequentially 0:00:00 [1/1] test_os test test_os crashed -- Traceback (most recent call last): File "/home/angwe

[issue28353] os.fwalk() unhandled exception when error occurs accessing symbolic link target

Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ _

[issue28353] os.fwalk() unhandled exception when error occurs accessing symbolic link target

Roundup Robot added the comment: New changeset 470224ec16b6 by Serhiy Storchaka in branch '3.5': Issue #28353: Fixed tests of os.fwalk() with broken links. https://hg.python.org/cpython/rev/470224ec16b6 -- ___ Python tracker

[issue28353] os.fwalk() unhandled exception when error occurs accessing symbolic link target

Roundup Robot added the comment: New changeset ec12e16ea6a1 by Serhiy Storchaka in branch '3.6': Issue #28353: Try to fix tests. https://hg.python.org/cpython/rev/ec12e16ea6a1 New changeset a0913dbadea6 by Serhiy Storchaka in branch 'default': Issue #28353: Try to fix tests. https://hg.python.or

[issue28353] os.fwalk() unhandled exception when error occurs accessing symbolic link target

Roundup Robot added the comment: New changeset fe1fea4ded04 by Serhiy Storchaka in branch '3.5': Issue #28353: os.fwalk() no longer fails on broken links. https://hg.python.org/cpython/rev/fe1fea4ded04 New changeset e99ec3c77a63 by Serhiy Storchaka in branch '3.6': Issue #28353: os.fwalk() no lo

[issue28353] os.fwalk() unhandled exception when error occurs accessing symbolic link target

Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue28353] os.fwalk() unhandled exception when error occurs accessing symbolic link target

Serhiy Storchaka added the comment: Here is a patch with tests. Needed to test it on Windows. -- stage: -> patch review ___ Python tracker ___ __

[issue28353] os.fwalk() unhandled exception when error occurs accessing symbolic link target

Changes by Serhiy Storchaka : -- keywords: +patch Added file: http://bugs.python.org/file44982/fwalk_oserror.patch ___ Python tracker ___

[issue28353] os.fwalk() unhandled exception when error occurs accessing symbolic link target

Samson Lee added the comment: This is definitely a bug because there is no way an unhandled exception like this is acceptable behaviour. The behaviour is that the fwalk iteration will stop and there is no way to recover / continue. Also fwalk takes an onerror callback function that won't be ca

[issue28353] os.fwalk() unhandled exception when error occurs accessing symbolic link target

Changes by Mariatta Wijaya : -- nosy: +Mariatta ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue28353] os.fwalk() unhandled exception when error occurs accessing symbolic link target

Serhiy Storchaka added the comment: Yes, there is a difference between os.walk() and os.fwalk() in some cases. I don't know whether it was introduced deliberately or by accident. os.fwalk() was added in issue13734, FileNotFoundError is used since issue14773. -- nosy: +hynek, loewis, ne

[issue28353] os.fwalk() unhandled exception when error occurs accessing symbolic link target

Samson Lee added the comment: Sorry, the target file needs to be in a directory you don't have permission to access: $ mkdir handsoff $ sudo chown root:root handsoff $ sudo chmod 700 handsoff $ ln -s handsoff/anything blah -- ___ Pyt

[issue28353] os.fwalk() unhandled exception when error occurs accessing symbolic link target

Serhiy Storchaka added the comment: I can't reproduce the issue. $ mkdir testdir $ touch testdir/handsoff $ sudo chown root:root testdir/handsoff $ sudo chmod 700 testdir/handsoff $ ln -s handsoff testdir/blah $ python3.5 >>> import os >>> list(os.walk('testdir')) [('testdir', [], ['handsoff', '

[issue28353] os.fwalk() unhandled exception when error occurs accessing symbolic link target

Samson Lee added the comment: Similar to http://bugs.python.org/issue25860 -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Pytho

[issue28353] os.fwalk() unhandled exception when error occurs accessing symbolic link target

New submission from Samson Lee: The bug is os.fwalk() crashes with unhandled exception when there is an error accessing symbolic link targets. To reproduce the bug, create a symbolic link that targets a file that you do not have permission to access: $ touch handsoff $ sudo chown root:r