[issue28435] test_urllib2_localnet.ProxyAuthTests fails with no_proxy and NO_PROXY env

2016-10-21 Thread Martin Panter
Martin Panter added the comment: I altered the comment (looks like it was a copy from code forcing proxies to be bypassed). Also, I didn’t port the second no_proxy fix to 2.7; it looks like there is a different workaround there which is not affected by the environment. -- resolution:

[issue28435] test_urllib2_localnet.ProxyAuthTests fails with no_proxy and NO_PROXY env

2016-10-21 Thread Roundup Robot
Roundup Robot added the comment: New changeset 8f4424bdeadc by Martin Panter in branch '2.7': Issue #28435: Avoid no_proxy environment variable interfering with tests https://hg.python.org/cpython/rev/8f4424bdeadc New changeset dc9ad44125de by Martin Panter in branch '3.5': Issue #28435: Avoid

[issue28435] test_urllib2_localnet.ProxyAuthTests fails with no_proxy and NO_PROXY env

2016-10-14 Thread Martin Panter
Martin Panter added the comment: The test tries using ProxyHandler directly. It looks like that handler intentionally ignores the request if it matches no_proxies (Issue 6894), so I think Piotr’s approach of adjusting the tests is correct. The patch looks good to me, though I would drop that

[issue28435] test_urllib2_localnet.ProxyAuthTests fails with no_proxy and NO_PROXY env

2016-10-14 Thread Łukasz Langa
Changes by Łukasz Langa : -- versions: +Python 3.6 ___ Python tracker ___ ___

[issue28435] test_urllib2_localnet.ProxyAuthTests fails with no_proxy and NO_PROXY env

2016-10-13 Thread Xiang Zhang
Changes by Xiang Zhang : -- nosy: +martin.panter ___ Python tracker ___ ___

[issue28435] test_urllib2_localnet.ProxyAuthTests fails with no_proxy and NO_PROXY env

2016-10-13 Thread Ned Deily
Changes by Ned Deily : -- nosy: +orsenthil stage: -> patch review ___ Python tracker ___

[issue28435] test_urllib2_localnet.ProxyAuthTests fails with no_proxy and NO_PROXY env

2016-10-13 Thread Stefan Prawda
Changes by Stefan Prawda : -- nosy: +lukasz.langa ___ Python tracker ___ ___

[issue28435] test_urllib2_localnet.ProxyAuthTests fails with no_proxy and NO_PROXY env

2016-10-13 Thread Stefan Prawda
New submission from Stefan Prawda: test_urllib2_localnet.ProxyAuthTests fails with no_proxy and NO_PROXY env set: NO_PROXY=localhost,127.0.0.0/8,::1 no_proxy=localhost,127.0.0.0/8,::1 Patch attached. Run: ./python -m unittest test.test_urllib2_localnet.ProxyAuthTests -v