[issue2848] Remove mimetools usage from the stdlib

Éric Araujo added the comment: Closing as outdated since 2.7 has been release with some mimetools usage left. -- resolution: -> out of date stage: -> committed/rejected status: open -> closed versions: +Python 2.7 -Python 2.6, Python 3.0 ___ Python

[issue2848] Remove mimetools usage from the stdlib

Changes by Éric Araujo : -- nosy: +Merwok ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org

[issue2848] Remove mimetools usage from the stdlib

Changes by Benjamin Peterson : -- priority: critical -> normal ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: h

[issue2848] Remove mimetools usage from the stdlib

Brett Cannon <[EMAIL PROTECTED]> added the comment: Benoit has a good point, so I have opened this issue again so we can get 2.7 even closer to 3.x compatibility. -- resolution: fixed -> status: closed -> open ___ Python tracker <[EMAIL PROTECTED]> <

[issue2848] Remove mimetools usage from the stdlib

Benoit Boissinot <[EMAIL PROTECTED]> added the comment: > Why does it need to be in 2.6? mimetools is still there. Because it outputs a warning with python2.6 -3, it's annoying for people trying to port their application to python3k -- nosy: +bboissin __

[issue2848] Remove mimetools usage from the stdlib

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: This is done. -- resolution: -> fixed status: open -> closed ___ Python tracker <[EMAIL PROTECTED]> ___ __

[issue2848] Remove mimetools usage from the stdlib

Barry A. Warsaw <[EMAIL PROTECTED]> added the comment: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Jun 12, 2008, at 8:57 AM, Benjamin Peterson wrote: > Benjamin Peterson <[EMAIL PROTECTED]> added the comment: > > On Wed, Jun 11, 2008 at 11:09 PM, Barry A. Warsaw > <[EMAIL PROTECTED]> wrote

[issue2848] Remove mimetools usage from the stdlib

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: On Wed, Jun 11, 2008 at 11:09 PM, Barry A. Warsaw <[EMAIL PROTECTED]> wrote: > > Barry A. Warsaw <[EMAIL PROTECTED]> added the comment: > > r64164 in Python 3.0. This doesn't apply cleanly to Python 2.6; could > someone please back port it

[issue2848] Remove mimetools usage from the stdlib

Barry A. Warsaw <[EMAIL PROTECTED]> added the comment: r64164 in Python 3.0. This doesn't apply cleanly to Python 2.6; could someone please back port it? -- priority: release blocker -> critical ___ Python tracker <[EMAIL PROTECTED]>

[issue2848] Remove mimetools usage from the stdlib

Barry A. Warsaw <[EMAIL PROTECTED]> added the comment: Actually, try this one. Added file: http://bugs.python.org/file10598/applied_mimetools.patch ___ Python tracker <[EMAIL PROTECTED]> _

[issue2848] Remove mimetools usage from the stdlib

Changes by Barry A. Warsaw <[EMAIL PROTECTED]>: Removed file: http://bugs.python.org/file10597/applied_mimetools.patch ___ Python tracker <[EMAIL PROTECTED]> ___ __

[issue2848] Remove mimetools usage from the stdlib

Barry A. Warsaw <[EMAIL PROTECTED]> added the comment: This patch works for me in Python 3.0. It's basically Humberto's patch with the two failing tests fixed. Added file: http://bugs.python.org/file10597/applied_mimetools.patch ___ Python tracker <[EMAIL PR

[issue2848] Remove mimetools usage from the stdlib

Raymond Hettinger <[EMAIL PROTECTED]> added the comment: Barry, can you take a look at this? Ideally, it should go it before the beta so it can get thoroughly exercised. ___ Python tracker <[EMAIL PROTECTED]>

[issue2848] Remove mimetools usage from the stdlib

Humberto Diogenes <[EMAIL PROTECTED]> added the comment: mimetools removal is almost complete, with the exception of only two broken tests: test_urllib2_localnet and test_xmlrpc. I'm not sure if it can make it to this beta, but at least it's really close. Added file: http://bugs.python.org/fil

[issue2848] Remove mimetools usage from the stdlib

Humberto Diogenes <[EMAIL PROTECTED]> added the comment: Raymond, thanks for the parser solution! It worked -- just broke some tests because of the nature of FeedParser. While rfc822.Message can read the file and stop at some point in the middle (meaning that self.fp can still be read), FeedPa

[issue2848] Remove mimetools usage from the stdlib

Raymond Hettinger <[EMAIL PROTECTED]> added the comment: -1 on the get_header() change. I would like this patch to be as minimal as possible. The new spelling is a bit awkward and it introduces an unnecessary change that could break code. ___ Python tracke

[issue2848] Remove mimetools usage from the stdlib

Humberto Diogenes <[EMAIL PROTECTED]> added the comment: As we're moving away from using .getheader() everywhere (file 10538), I think it's a good time to make HTTPResponse conform to PEP8 and define .get_header (with underscore) instead. Added file: http://bugs.python.org/file10541/rename_HT

[issue2848] Remove mimetools usage from the stdlib

Humberto Diogenes <[EMAIL PROTECTED]> added the comment: Attached a patch to rename all calls to the mimetools-specific .getheader() to .get(), which works on both libraries (mimetools and email.Message). That eases transition without breaking any tests. Added file: http://bugs.python.org/file

[issue2848] Remove mimetools usage from the stdlib

Changes by Humberto Diogenes <[EMAIL PROTECTED]>: Added file: http://bugs.python.org/file10537/email.parser-small_fix.patch ___ Python tracker <[EMAIL PROTECTED]> ___ _

[issue2848] Remove mimetools usage from the stdlib

Raymond Hettinger <[EMAIL PROTECTED]> added the comment: One idea: in http.client.HTTPMessage, inherit from email.Message, modify the addheaders/addcontinue/readheaders methods to use the methods in Message. Then, change the instantiation in HTTPResponse to self.msg = email.parser.Parser(_c

[issue2848] Remove mimetools usage from the stdlib

Humberto Diogenes <[EMAIL PROTECTED]> added the comment: It's relatively easy to replace mimetools in most places: it's just a matter of changing mimetools.Message to email.message_from_file, but it gets a lot more complicated when there's inheritance involved. The problem is that mimetools.Me

[issue2848] Remove mimetools usage from the stdlib

Changes by Humberto Diogenes <[EMAIL PROTECTED]>: Removed file: http://bugs.python.org/file10515/remove_mimetools_from_urllib.patch ___ Python tracker <[EMAIL PROTECTED]> ___

[issue2848] Remove mimetools usage from the stdlib

Changes by Humberto Diogenes <[EMAIL PROTECTED]>: Added file: http://bugs.python.org/file10516/remove_mimetools_from_urllib.patch-2 ___ Python tracker <[EMAIL PROTECTED]> ___

[issue2848] Remove mimetools usage from the stdlib

Humberto Diogenes <[EMAIL PROTECTED]> added the comment: I'm sending a patch that removes mimetools from urllib and test_urllib. It now returns an email.message.Message instead of mimetools.Message. I also moved some imports to the top of the file. If that's a problem, I can send another patch

[issue2848] Remove mimetools usage from the stdlib

Humberto Diogenes <[EMAIL PROTECTED]> added the comment: The only use of mimetools inside cgi is in parse_multipart, which is untested and has huge warnings like these ones: """ XXX This does not parse nested multipart parts -- use FieldStorage for that. XXX This should really be subsumed by F

[issue2848] Remove mimetools usage from the stdlib

Raymond Hettinger <[EMAIL PROTECTED]> added the comment: The APIs are bit different, but it should be possible to migrate from the old to the new. All the key functionality is there. Barry, any thoughts on transitioning away from the deprecated modules? -- assignee: -> barry nosy: +r

[issue2848] Remove mimetools usage from the stdlib

Brett Cannon <[EMAIL PROTECTED]> added the comment: I don't know how compatible it is. __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list mailing lis

[issue2848] Remove mimetools usage from the stdlib

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: mimetools.Message is compatible with email.message.Message, right? -- nosy: +barry, benjamin.peterson __ Tracker <[EMAIL PROTECTED]> __

[issue2848] Remove mimetools usage from the stdlib

Changes by Brett Cannon <[EMAIL PROTECTED]>: -- priority: critical -> release blocker __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list mai

[issue2848] Remove mimetools usage from the stdlib

New submission from Brett Cannon <[EMAIL PROTECTED]>: The mimetools module has been deprecated for ages, but it is still used in multiple places (a quick grep lists ``cgi``, ``httplib``, ``urllib``, ``urllib2``, ``test_cookielib``, ``test_multifile``, ``test_urllib``, ``test_urllib2``, ``test_