[issue28598] RHS not consulted in `str % subclass_of_str` case.

Changes by Donald Stufft : -- pull_requests: +1103 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue28598] RHS not consulted in `str % subclass_of_str` case.

Serhiy Storchaka added the comment: New changeset d7e64337ef45085792b382a09f5b3a45d3687c8c by Serhiy Storchaka (Martijn Pieters) in branch 'master': bpo-28598: Support __rmod__ for RHS subclasses of str in % string formatting operations (#51) https://github.com/python/cpython/commit/d7e64337ef

[issue28598] RHS not consulted in `str % subclass_of_str` case.

Berker Peksag added the comment: New changeset 53039ad3814a8918c5311f37bd654428b9843fcc by Berker Peksag (Martijn Pieters) in branch '3.6': bpo-28598: Support __rmod__ for RHS subclasses of str in % string formatting operations (#95) https://github.com/python/cpython/commit/53039ad3814a8918c53

[issue28598] RHS not consulted in `str % subclass_of_str` case.

Berker Peksag added the comment: New changeset bc144f0abff2b36595171377ee847c0266596ab2 by Berker Peksag (Martijn Pieters) in branch '3.5': bpo-28598: Support __rmod__ for RHS subclasses of str in % string formatting operations (#94) https://github.com/python/cpython/commit/bc144f0abff2b365951

[issue28598] RHS not consulted in `str % subclass_of_str` case.

Xiang Zhang added the comment: New changeset b4f0e980b6084e9a994e3f069269fac2471e0d78 by Xiang Zhang in branch '2.7': bpo-28598: Support __rmod__ for RHS subclasses of str in % string formatting operations (GH-366) https://github.com/python/cpython/commit/b4f0e980b6084e9a994e3f069269fac2471e0d

[issue28598] RHS not consulted in `str % subclass_of_str` case.

Changes by Larry Hastings : -- pull_requests: +619 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue28598] RHS not consulted in `str % subclass_of_str` case.

Changes by Martijn Pieters : -- pull_requests: +318 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue28598] RHS not consulted in `str % subclass_of_str` case.

Changes by Xiang Zhang : -- resolution: -> fixed stage: needs patch -> resolved status: open -> closed ___ Python tracker ___ ___ Pyt

[issue28598] RHS not consulted in `str % subclass_of_str` case.

Changes by Xiang Zhang : -- pull_requests: +310 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue28598] RHS not consulted in `str % subclass_of_str` case.

Changes by Serhiy Storchaka : -- resolution: fixed -> stage: resolved -> needs patch status: closed -> open versions: +Python 2.7 -Python 3.5, Python 3.6, Python 3.7 ___ Python tracker

[issue28598] RHS not consulted in `str % subclass_of_str` case.

Martijn Pieters added the comment: > Is 2.7 free from this bug? No, 2.7 is affected too: >>> class SubclassedStr(str): ... def __rmod__(self, other): ... return 'Success, self.__rmod__({!r}) was called'.format(other) ... >>> 'lhs %% %r' % SubclassedStr('rhs') "lhs % 'rhs'" Expected

[issue28598] RHS not consulted in `str % subclass_of_str` case.

Serhiy Storchaka added the comment: Is 2.7 free from this bug? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe

[issue28598] RHS not consulted in `str % subclass_of_str` case.

Changes by Berker Peksag : -- versions: -Python 2.7 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue28598] RHS not consulted in `str % subclass_of_str` case.

Changes by Berker Peksag : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue28598] RHS not consulted in `str % subclass_of_str` case.

Changes by Martijn Pieters : -- pull_requests: +299 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue28598] RHS not consulted in `str % subclass_of_str` case.

Changes by Martijn Pieters : -- pull_requests: +294 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue28598] RHS not consulted in `str % subclass_of_str` case.

Changes by Serhiy Storchaka : -- pull_requests: +218 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue28598] RHS not consulted in `str % subclass_of_str` case.

Changes by Serhiy Storchaka : -- pull_requests: -57 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue28598] RHS not consulted in `str % subclass_of_str` case.

Changes by Martijn Pieters : -- pull_requests: +57 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue28598] RHS not consulted in `str % subclass_of_str` case.

Changes by Serhiy Storchaka : -- nosy: +serhiy.storchaka stage: -> patch review versions: +Python 3.7 -Python 3.3, Python 3.4 ___ Python tracker ___

[issue28598] RHS not consulted in `str % subclass_of_str` case.

Martijn Pieters added the comment: I'm not sure if issues are linked automatically yet. I put the patch up as a pull request on GitHub: https://github.com/python/cpython/pull/51 -- ___ Python tracker _

[issue28598] RHS not consulted in `str % subclass_of_str` case.

Martijn Pieters added the comment: Here's a proposed patch for tip; what versions would it be worth backporting this to? (Note, there's no NEWS update in this patch). -- keywords: +patch Added file: http://bugs.python.org/file45338/issue28598.patch

[issue28598] RHS not consulted in `str % subclass_of_str` case.

Changes by Xiang Zhang : -- nosy: +xiang.zhang ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyt

[issue28598] RHS not consulted in `str % subclass_of_str` case.

New submission from Martijn Pieters: The `BINARY_MODULO` operator hardcodes a test for `PyUnicode`: TARGET(BINARY_MODULO) { PyObject *divisor = POP(); PyObject *dividend = TOP(); PyObject *res = PyUnicode_CheckExact(dividend) ? PyUnicod