[issue28621] Refactor duplicate code calculating digit's bit length

Changes by Donald Stufft : -- pull_requests: +845 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue28621] Refactor duplicate code calculating digit's bit length

Serhiy Storchaka added the comment: Thank you Adrian for your contribution. -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker __

[issue28621] Refactor duplicate code calculating digit's bit length

Roundup Robot added the comment: New changeset 1940b72b0a02 by Serhiy Storchaka in branch 'default': Issue #28621: Sped up converting int to float by reusing faster bits counting https://hg.python.org/cpython/rev/1940b72b0a02 -- nosy: +python-dev ___

[issue28621] Refactor duplicate code calculating digit's bit length

Mark Dickinson added the comment: LGTM, too. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue28621] Refactor duplicate code calculating digit's bit length

Serhiy Storchaka added the comment: LGTM. -- nosy: +serhiy.storchaka stage: patch review -> commit review ___ Python tracker ___ ___ P

[issue28621] Refactor duplicate code calculating digit's bit length

Changes by SilentGhost : -- nosy: +mark.dickinson stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Uns

[issue28621] Refactor duplicate code calculating digit's bit length

Changes by Adrian Wielgosik : -- keywords: +patch Added file: http://bugs.python.org/file45367/bit_length.patch ___ Python tracker ___ ___

[issue28621] Refactor duplicate code calculating digit's bit length

New submission from Adrian Wielgosik: The attached patch uses an existing function bits_in_digit() in two other functions: - in long_bit_length() - it already had identical logic - in _PyLong_NumBits() - it used a naive, slower way of calculating bit length, so as an added bonus the patch spee