[issue28783] Embedded/nuget packages incorrectly reference bdist_wininst

Ned Deily added the comment: [cherrypicked for 3.6.0rc2] -- priority: release blocker -> resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker

[issue28783] Embedded/nuget packages incorrectly reference bdist_wininst

Roundup Robot added the comment: New changeset 1f69fb337288 by Steve Dower in branch '3.6': Issue #28783: Replaces bdist_wininst in nuget packages with stub https://hg.python.org/cpython/rev/1f69fb337288 -- ___ Python tracker

[issue28783] Embedded/nuget packages incorrectly reference bdist_wininst

Roundup Robot added the comment: New changeset 47bf09270027 by Steve Dower in branch '3.5': Issue #28783: Replaces bdist_wininst in nuget packages with stub https://hg.python.org/cpython/rev/47bf09270027 New changeset b8b1ad21e073 by Steve Dower in branch '3.6': Issue #28783: Replaces

[issue28783] Embedded/nuget packages incorrectly reference bdist_wininst

Steve Dower added the comment: Thanks Ned, it's all yours. -- stage: patch review -> commit review ___ Python tracker ___

[issue28783] Embedded/nuget packages incorrectly reference bdist_wininst

Ned Deily added the comment: Just do your normal thing. I'll make it work. -- ___ Python tracker ___ ___

[issue28783] Embedded/nuget packages incorrectly reference bdist_wininst

Steve Dower added the comment: Is it easy to cherry pick a merge commit? This will go into 3.5 first, but I can null merge and then clean commit it if that's easier? -- ___ Python tracker

[issue28783] Embedded/nuget packages incorrectly reference bdist_wininst

Paul Moore added the comment: I'm OK for this to go in. -- ___ Python tracker ___ ___ Python-bugs-list

[issue28783] Embedded/nuget packages incorrectly reference bdist_wininst

Ned Deily added the comment: I agree that the risk if this is applied appears to be minimal. If Paul or Zack are OK with it and your testing is successful, I'll plan on cherrypicking it for 3.6.0 final. -- ___ Python tracker

[issue28783] Embedded/nuget packages incorrectly reference bdist_wininst

Steve Dower added the comment: I have a better fix for this issue in the attached patch. It doesn't require any change to setuptools in order to avoid crashing when installing from sdist (e.g. Cython). As before, this only involves changing the nuget package and its build scripts, so there

[issue28783] Embedded/nuget packages incorrectly reference bdist_wininst

Steve Dower added the comment: Thanks. For reference, the setuptools issue is https://github.com/pypa/setuptools/issues/857 A setuptools install from source should be fixed by this change, though an install from a wheel (which is now typical, unfortunately) requires a separate fix. But

[issue28783] Embedded/nuget packages incorrectly reference bdist_wininst

Roundup Robot added the comment: New changeset f7aa200bed8d by Steve Dower in branch '3.5': Issue #28783: Embedded and nuget packages incorrect reference missing bdist_wininst command. https://hg.python.org/cpython/rev/f7aa200bed8d New changeset a3755890545c by Steve Dower in branch '3.6':

[issue28783] Embedded/nuget packages incorrectly reference bdist_wininst

Steve Dower added the comment: A convenient test is: python.exe -c "import distutils.core; distutils.core.setup()" --help-comm ands Without the fix, it raises "distutils.errors.DistutilsModuleError: invalid command 'bdist_wininst'". But yes, unfortunately the fix is not particularly

[issue28783] Embedded/nuget packages incorrectly reference bdist_wininst

Paul Moore added the comment: I've had a look. I agree in principle with the change, and the code looks OK on inspection, although I can't really test it. As it's only a change to one of the scripts in tools/msi, this seems like a low-risk change to me, so I'm OK with it. --

[issue28783] Embedded/nuget packages incorrectly reference bdist_wininst

Ned Deily added the comment: I'd like one of the other Windows folks to review it but, in principle, LGTM. -- ___ Python tracker ___

[issue28783] Embedded/nuget packages incorrectly reference bdist_wininst

Steve Dower added the comment: The full fix may also require updating setuptools, which I'm pursuing, but we also should stop referring to a module that isn't there. -- ___ Python tracker

[issue28783] Embedded/nuget packages incorrectly reference bdist_wininst

New submission from Steve Dower: For the embedded zip and nuget releases, I've omitted bdist_wininst. However, I forgot to remove the reference to it from distutils.command.__init__.__all__, and so setuptools will occasionally crash trying to import it. This patch updates