[issue28860] Fixed all the doctest failures in Doc/library/configparser.rst

Marco Buttu added the comment: I attached a patch in issue 27200 that makes all doctests pass, so I close here. -- resolution: -> duplicate status: open -> closed ___ Python tracker ___

[issue28860] Fixed all the doctest failures in Doc/library/configparser.rst

Marco Buttu added the comment: Here is a 3rd patch. I used a generator expression argument to ``sorted()``, as recommend by Zachary. Thank you very much for all your suggestions -- Added file: http://bugs.python.org/file45745/configparser3rd.patch __

[issue28860] Fixed all the doctest failures in Doc/library/configparser.rst

Zachary Ware added the comment: Indeed, thank you Marco for continuing this work! The patches that I committed [1] were mostly done by Jelle Zijlstra. There were not many tests that had dict ordering issues; but it looks like we used sorted() rather than list() in a few places. I think using

[issue28860] Fixed all the doctest failures in Doc/library/configparser.rst

Terry J. Reedy added the comment: For some reason, not obvious to me, these patches cannot be reviewed on Rietveld. -- ___ Python tracker ___ ___

[issue28860] Fixed all the doctest failures in Doc/library/configparser.rst

Terry J. Reedy added the comment: Marco, thank you for adding more energy to improving the docs. #27200 is the master issue for fixing failing doc doctests. The goal is to be able to have a buildbot run 'make doctest' or the Windows equivalent and expect success. For this issue, I mildly agre

[issue28860] Fixed all the doctest failures in Doc/library/configparser.rst

Marco Buttu added the comment: I usually keep the code examples focused, because I think extra code added just in order to have more tests can get the example less clear. But of course, there is an important downside :/ So, if your policy and goal is to have a better coverage of the code examp

[issue28860] Fixed all the doctest failures in Doc/library/configparser.rst

Brett Cannon added the comment: For the iteration of dictionary keys, can you pass the keys through sorted() to have a deterministic order? -- nosy: +brett.cannon ___ Python tracker ___

[issue28860] Fixed all the doctest failures in Doc/library/configparser.rst

New submission from Marco Buttu: With Python 3.7.0a0 and sphinx-build 1.4.9, this was the result before applying the patch: Doctest summary === 80 tests 8 failures in tests 0 failures in setup code 0 failures in cleanup code build finished with problems, 139 warnings