[issue29034] refleak in path_converter on error case

2016-12-21 Thread Xiang Zhang
Xiang Zhang added the comment: Ohh, I haven't read all related code so I didn't realize that's a leak. But if that is, there is still a wide = PyUnicode_AsWideCharString around the codes I altered. -- ___ Python tracker

[issue29034] refleak in path_converter on error case

2016-12-21 Thread STINNER Victor
STINNER Victor added the comment: Oh crap, memory leaks on Windows are rarely checked. I recall that I found a huge memory leak on Windows just before Python 3.6 beta 1 release: changeset: 103956:6232e610e310 branch: 3.6 parent: 103954:c1d9052996f1 user:Victor Stinner

[issue29034] refleak in path_converter on error case

2016-12-21 Thread Xiang Zhang
New submission from Xiang Zhang: It looks like the bytes variable should be Py_DECREFed on error cases as the patch shows. -- components: Library (Lib) files: path_converter.patch keywords: patch messages: 283736 nosy: haypo, steve.dower, xiang.zhang priority: normal severity: normal