[issue29084] C API of OrderedDict

2017-12-24 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ _

[issue29084] C API of OrderedDict

2017-12-24 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset d62b7412c18bd5dfa6d7346abfaf8a922818e6db by Serhiy Storchaka (Miss Islington (bot)) in branch '3.6': bpo-29084: Exclude C API for OrderedDict from the limited C API. (GH-4900) (#5007) https://github.com/python/cpython/commit/d62b7412c18bd5dfa6

[issue29084] C API of OrderedDict

2017-12-24 Thread Roundup Robot
Change by Roundup Robot : -- pull_requests: +4896 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue29084] C API of OrderedDict

2017-12-24 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 1b3029ac8370ac76fa9571aef540e10aed0667ff by Serhiy Storchaka in branch 'master': bpo-29084: Exclude C API for OrderedDict from the limited C API. (#4900) https://github.com/python/cpython/commit/1b3029ac8370ac76fa9571aef540e10aed0667ff --

[issue29084] C API of OrderedDict

2017-12-16 Thread Raymond Hettinger
Raymond Hettinger added the comment: With today's announcement of guaranteed ordering for regular dicts, OrderedDict just became much less important (almost insignificant). Also, the original reason for having this C API no longer applies. There is a reasonable case to be made for removing t

[issue29084] C API of OrderedDict

2017-12-16 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +4795 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-

[issue29084] C API of OrderedDict

2017-10-23 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- assignee: -> serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue29084] C API of OrderedDict

2017-01-22 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Eric, what are your thoughts? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscr

[issue29084] C API of OrderedDict

2016-12-28 Thread Raymond Hettinger
Raymond Hettinger added the comment: +1 for privatizing -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http

[issue29084] C API of OrderedDict

2016-12-27 Thread Brett Cannon
Brett Cannon added the comment: If the API is broken in the limited API then I definitely think we should consistently make it not part of the limited API. As for removing it I don't have an opinion without knowing how many people are using it. -- nosy: +brett.cannon

[issue29084] C API of OrderedDict

2016-12-27 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: C API of the C implementation of OrderedDict was added in 3.5 together with the C implementation of OrderedDict. But it was never announced nor documented. Some macros contain bugs. PyODict_Check() and PyODict_CheckExact() are declared in the limited API,