[issue29296] convert print() to METH_FASTCALL

STINNER Victor added the comment: Since the title of the issue is "convert print() to METH_FASTCALL", I consider that the issue is now done. As I wrote, as soon as AC will support **kwargs, we will be able to print() to use AC. Thanks Naoki for the change. -- dependencies: -Argument

[issue29296] convert print() to METH_FASTCALL

INADA Naoki added the comment: > Can we close the issue, or do you prefer to keep it open? I don't care. -- ___ Python tracker ___

[issue29296] convert print() to METH_FASTCALL

STINNER Victor added the comment: Serhiy Storchaka: > When the fastcall protocol be changed, this would require changing more > handwritten code. I don't plan to modify the fastcall protocol. I'm not sure that it's really possible to modify it anymore. It would probably be simpler to add a new

[issue29296] convert print() to METH_FASTCALL

Serhiy Storchaka added the comment: > Why can't we start with METH_FASTCALL and convert to AC later? It increases the maintenance burden. When the fastcall protocol be changed, this would require changing more handwritten code. -- ___ Python

[issue29296] convert print() to METH_FASTCALL

STINNER Victor added the comment: I pushed print-fastcall.patch since it's simple and has a significant impact on bm_telco benchmark (especially when tp_fastcall slot will be added). I added a reminder (msg285779) in #20291 to convert print() once AC will support **kwargs. Can we close the

[issue29296] convert print() to METH_FASTCALL

Roundup Robot added the comment: New changeset 0327171f05dd by INADA Naoki in branch 'default': Issue #29296: convert print() to METH_FASTCALL https://hg.python.org/cpython/rev/0327171f05dd -- nosy: +python-dev ___ Python tracker

[issue29296] convert print() to METH_FASTCALL

STINNER Victor added the comment: Serhiy Storchaka: "Please wait until the support of var-positional arguments be added in Argument Clinic. After that print() could be just converted to Argument Clinic." Why can't we start with METH_FASTCALL and convert to AC later? It seems like

[issue29296] convert print() to METH_FASTCALL

Serhiy Storchaka added the comment: Please wait until the support of var-positional arguments be added in Argument Clinic. After that print() could be just converted to Argument Clinic. -- ___ Python tracker

[issue29296] convert print() to METH_FASTCALL

STINNER Victor added the comment: I reviewed print-fastcall.patch: LGTM, but I proposed a minor change. Serhiy Storchaka: "The performance of print() is not critical. It usually involves slow formatting and IO." I also had the same understanding of print(), but I just analyzed performances

[issue29296] convert print() to METH_FASTCALL

STINNER Victor added the comment: Hi, Serhiy Storchaka: "The performance of print() is not critical. It usually involves slow formatting and IO." Oh, please, I want a print() using METH_FASTCALL! Not for the performance, but just to help me in my development! To identify code not using

[issue29296] convert print() to METH_FASTCALL

INADA Naoki added the comment: I see. AC should support this. -- dependencies: +Argument Clinic should understand *args and **kwargs parameters resolution: -> later status: open -> pending ___ Python tracker

[issue29296] convert print() to METH_FASTCALL

Serhiy Storchaka added the comment: The performance of print() is not critical. It usually involves slow formatting and IO. _PyArg_ParseStackAndKeywords() is a part of unstable, fast-evolved API. I would beware of using it in common code. -- nosy: +serhiy.storchaka

[issue29296] convert print() to METH_FASTCALL

New submission from INADA Naoki: Median +- std dev: [default] 24.2 ms +- 0.4 ms -> [patched] 19.2 ms +- 0.4 ms: 1.26x faster (-21%) -- files: print-fastcall.patch keywords: patch messages: 285632 nosy: haypo, inada.naoki priority: normal severity: normal status: open title: convert