[issue29400] Add instruction level tracing via sys.settrace

Change by STINNER Victor : -- resolution: -> rejected ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:

[issue29400] Add instruction level tracing via sys.settrace

George King added the comment: Nick's implementation of f_trace_lines/f_trace_opcodes serves the same purpose as my proposal, and is a simpler solution so I'm abandoning this patch and working with that feature instead. -- stage: test needed -> resolved status: open -> closed ___

[issue29400] Add instruction level tracing via sys.settrace

STINNER Victor added the comment: See also bpo-31344 and PR #3417: New changeset 5a8516701f5140c8c989c40e261a4f4e20e8af86 by Nick Coghlan in branch 'master': bpo-31344: Per-frame control of trace events (GH-3417) https://github.com/python/cpython/commit/5a8516701f5140c8c989c40e261a4f4e20e8af86

[issue29400] Add instruction level tracing via sys.settrace

Change by Jakub Wilk : -- nosy: +jwilk ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org

[issue29400] Add instruction level tracing via sys.settrace

Change by Fred L. Drake, Jr. : -- nosy: +fdrake ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue29400] Add instruction level tracing via sys.settrace

STINNER Victor added the comment: The main blocker question is the API change. I started a thread on python-dev to discuss it: https://mail.python.org/pipermail/python-dev/2017-September/149632.html -- ___ Python tracker

[issue29400] Add instruction level tracing via sys.settrace

Changes by George King : -- pull_requests: +3278 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue29400] Add instruction level tracing via sys.settrace

George King added the comment: Attached updated demo script. -- Added file: http://bugs.python.org/file47107/settracestate-demo.py ___ Python tracker ___

[issue29400] Add instruction level tracing via sys.settrace

George King added the comment: (Also I did prototype instruction filtering but it had mild performance implications when tracing so I have shelved it for the moment.) -- ___ Python tracker

[issue29400] Add instruction level tracing via sys.settrace

George King added the comment: I've updated the patch and I think it's ready for a more serious review. A few notes: * settracestate now takes a flag `trace_instructions`. This describes slightly better the behavior, which is that line events take precedence over instructions. * the old gett

[issue29400] Add instruction level tracing via sys.settrace

George King added the comment: After reviewing the thread, I'm reminded that the main design problem concerns preserving behavior of this idiom: "old=sys.gettrace(); ...; sys.settrace(old)" If we add more state, i.e. the `trace_instructions` bool, then the above idiom no longer correctly store

[issue29400] Add instruction level tracing via sys.settrace

STINNER Victor added the comment: See aslo issue #29502: "Should PyObject_Call() call the profiler on C functions, use C_TRACE() macro?" -- ___ Python tracker ___ __

[issue29400] Add instruction level tracing via sys.settrace

George King added the comment: I'm not sure exactly, but the way I see it (for code coverage), we want to trace transitions between basic blocks. So I would define it as: each entry into a BB is traced, with a tuple of (previous_offset, current_offset). This way when a function call starts, we

[issue29400] Add instruction level tracing via sys.settrace

STINNER Victor added the comment: > I did it this way because I would like to consider adding a third mode, which > would only trigger tracing for interesting control-flow events, namely steps > for which the previous instruction was a branch. Hum, let's use https://en.wikipedia.org/wiki/Basic

[issue29400] Add instruction level tracing via sys.settrace

George King added the comment: Attached is a new patch, which does not settrace/gettrace and instead offers new settraceinst/gettraceinst per Victor's recommendation. I did not implement the proposed behavior of raising an exception if the old APIs are used when the inst_tracing flag is set. H

[issue29400] Add instruction level tracing via sys.settrace

Changes by Terry J. Reedy : -- stage: -> test needed title: Instruction level tracing via sys.settrace -> Add instruction level tracing via sys.settrace versions: +Python 3.7 -Python 3.6 ___ Python tracker __