[issue29463] Change docstring to attribute from first statement.

2017-02-07 Thread INADA Naoki
Changes by INADA Naoki : Added file: http://bugs.python.org/file46569/ast-docstring-3.patch ___ Python tracker ___ ___ Python-bugs-list mailin

[issue29463] Change docstring to attribute from first statement.

2017-02-07 Thread INADA Naoki
INADA Naoki added the comment: lnotab is changed too. -0,0,0,115,12,0,0,0,8,4,4,2,8,8,8,12, -8,25,8,13,114,18,0,0,0,99,0,0,0,0,0,0, +0,0,0,115,10,0,0,0,12,6,8,8,8,12,8,25, +8,13,114,18,0,0,0,99,0,0,0,0,0,0,0,0, 115 is header for bytes type. next 4 bytes is it's length (little en

[issue29463] Change docstring to attribute from first statement.

2017-02-07 Thread INADA Naoki
Changes by INADA Naoki : Added file: http://bugs.python.org/file46567/ast-docstring-2.patch ___ Python tracker ___ ___ Python-bugs-list mailin

[issue29463] Change docstring to attribute from first statement.

2017-02-07 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I like this change. Added comments on Rietveld. Are changes in importlib.h only due to changing first line numbers? -- components: +Interpreter Core nosy: +benjamin.peterson, georg.brandl, serhiy.storchaka stage: -> patch review type: -> enhancement

[issue29463] Change docstring to attribute from first statement.

2017-02-07 Thread STINNER Victor
STINNER Victor added the comment: I like the change because (IMHO) it makes the code simpler, and becase it also changes the first line of code object. I reviewed the patch: need basic unit tests. -- ___ Python tracker

[issue29463] Change docstring to attribute from first statement.

2017-02-06 Thread INADA Naoki
New submission from INADA Naoki: spin off of #11549. http://bugs.python.org/issue11549#msg130955 > b) Docstring is now an attribute of Module, FunctionDef and ClassDef, > > rather than a first statement. Docstring is a special syntactic > construction, it's not an executable code, so it makes