[issue2953] _zip_directory_cache untested and undocumented

Changes by Terry J. Reedy : -- versions: +Python 3.3 -Python 3.1, Python 3.2 ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue2953] _zip_directory_cache untested and undocumented

Éric Araujo added the comment: No problem (and congratulations :) -- nosy: +ncoghlan ___ Python tracker ___ ___ Python-bugs-list mailin

[issue2953] _zip_directory_cache untested and undocumented

Eric Snow added the comment: I'll take a look but can't say when. My wife's is having a baby in the next couple days so I'm a bit swamped. :) -- ___ Python tracker ___

[issue2953] _zip_directory_cache untested and undocumented

Éric Araujo added the comment: Eric, as you know importlib, can you comment about this? If zipimport now works with the invalidate_caches system, then we do have a documented way of clearing the cache, and I would recommend closing this bug (the existing attribute should stay for compat, but

[issue2953] _zip_directory_cache untested and undocumented

Changes by Brett Cannon : -- nosy: -brett.cannon ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.py

[issue2953] _zip_directory_cache untested and undocumented

Éric Araujo added the comment: Could the recently-added functools.lru_cache help here? -- components: -Distutils nosy: +eric.araujo versions: +Python 3.2 ___ Python tracker ___

[issue2953] _zip_directory_cache untested and undocumented

Changes by Éric Araujo : Removed file: http://bugs.python.org/file13638/unnamed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubs

[issue2953] _zip_directory_cache untested and undocumented

Changes by Éric Araujo : Removed file: http://bugs.python.org/file13625/unnamed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubs

[issue2953] _zip_directory_cache untested and undocumented

Brett Cannon added the comment: 2009/4/5 <"Tarek Ziadé "@psf.upfronthosting.co.za> > > Tarek Ziadé added the comment: > > > Does distutils use _zip_directory_cache in any way? > > Not at all. But pkgutil does, Ah, OK. > and uses to get a dirlist, Couldn't one just open the zip file with z

[issue2953] _zip_directory_cache untested and undocumented

Tarek Ziadé added the comment: > Does distutils use _zip_directory_cache in any way? Not at all. But pkgutil does, and uses to get a dirlist, so I guess a new API should be created in zipimport to handle this case as well. (I think it's some setuptools code originallyt, that landed in pkgutil)

[issue2953] _zip_directory_cache untested and undocumented

Brett Cannon added the comment: Does distutils use _zip_directory_cache in any way? If not then setuptools is in the wrong here for using a private attribute and it is on them to make it work if the attribute does not exist, period. Otherwise someone will need to come up with a very simple API

[issue2953] _zip_directory_cache untested and undocumented

Maciek Fijalkowski added the comment: setuptools at least deletes stuff from _zip_directory_cache (via _uncache function in easy_install.py). it also iterates over it and checks for existance of elements. What about documenting details about _zip_directory_cache: * does it need to be a normal p

[issue2953] _zip_directory_cache untested and undocumented

Tarek Ziadé added the comment: maybe what's missing is a public API for the clear() method since setuptools uses it by calling it directly -- ___ Python tracker ___ _

[issue2953] _zip_directory_cache untested and undocumented

Tarek Ziadé added the comment: I am not sure what you would like to see added. in zipimport.c: "- _zip_directory_cache: a dict, mapping archive paths to zip directory info dicts, as used in zipimporter._files. " while there are no direct test, Lib/test/test_zipimport.py covers it becauseit

[issue2953] _zip_directory_cache untested and undocumented

Maciek Fijalkowski added the comment: it == _zip_directory_cache -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue2953] _zip_directory_cache untested and undocumented

Tarek Ziadé added the comment: > while it has no single tests and no documentation." what "it" refers to ? zipimport, distutils or setuptools ? -- ___ Python tracker ___ ___

[issue2953] _zip_directory_cache untested and undocumented

Maciek Fijalkowski added the comment: The bug with this is that setuptools uses it (and even relies on what is there and in what order), while it has no single tests and no documentation. -- ___ Python tracker

[issue2953] _zip_directory_cache untested and undocumented

Tarek Ziadé added the comment: _zip_directory_cache is part of the zipimport module (C module) you can find in Modules/zipimport.c. The tests are located here: ./Lib/test/test_zipimport.py _zip_directory_cache is a dict used by zipimporter_init to speed up the lookup. Notice that if it is suc

[issue2953] _zip_directory_cache untested and undocumented

Changes by Tarek Ziadé : -- priority: -> normal versions: +Python 2.7, Python 3.1 -Python 2.6 ___ Python tracker ___ ___ Python-bugs-l

[issue2953] _zip_directory_cache untested and undocumented

Brett Cannon added the comment: Actually importlib does not test this; that is an old thing from an old sandbox version of importlib that I no longer use. I am assigning to Tarek as the better solution is for distutils to stop using this "private" attribute. -- assignee: brett.cannon -

[issue2953] _zip_directory_cache untested and undocumented

Georg Brandl added the comment: That's fortunate, because I can just reassign this to him :) -- assignee: georg.brandl -> brett.cannon nosy: +brett.cannon ___ Python tracker ___

[issue2953] _zip_directory_cache untested and undocumented

Maciek Fijalkowski added the comment: Seems I meant setuptools indeed. Note that brett's importlib contains some tests for _zip_directory_cache. -- ___ Python tracker ___ ___

[issue2953] _zip_directory_cache untested and undocumented

Georg Brandl added the comment: I can't find a reference to _zip_directory_cache in distutils. Do you mean setuptools? -- ___ Python tracker ___

[issue2953] _zip_directory_cache untested and undocumented

Changes by Daniel Diniz : -- nosy: +tarek ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org

[issue2953] _zip_directory_cache untested and undocumented

New submission from Maciek Fijalkowski <[EMAIL PROTECTED]>: _zip_directory_cache has no single test nor piece of documentation. The only place where it's mentioned is a call to method .clear() on it in tests. Besides, it can be whatever. Despite _ prefix, which I would consider to be private, dis