[issue29796] [2.7] test_weakref hangs on Python 2.7 on Windows

STINNER Victor added the comment: Yep, I didn't see any test_weakref hang anymore since this commit. -- ___ Python tracker ___ ___

[issue29796] [2.7] test_weakref hangs on Python 2.7 on Windows

Zachary Ware added the comment: Looks like we forgot to close this one; as far as I can tell it was fixed. Being 2.7-only, it's time to be closed anyway :) -- resolution: -> fixed stage: test needed -> resolved status: open -> closed ___ Python t

[issue29796] [2.7] test_weakref hangs on Python 2.7 on Windows

STINNER Victor added the comment: With commit 1fef0154d97bd7f01c5bc59954a278bacf1a3f0e, test_weakref takes 11 seconds on my Windows VM. Without this fix, test_weakref runs for longer than 2 hour and 19 min on my Windows VM. I decided to kill the test, I don't want to burn my CPU too long :-)

[issue29796] [2.7] test_weakref hangs on Python 2.7 on Windows

STINNER Victor added the comment: Oh wow! The commit 1fef0154d97bd7f01c5bc59954a278bacf1a3f0e fixed PGO compilation on Python 2.7: http://buildbot.python.org/all/builders/AMD64%20Debian%20PGO%202.7/builds/227 is the first successful build since June 20. I didn't notice that the PGO buildbot w

[issue29796] [2.7] test_weakref hangs on Python 2.7 on Windows

STINNER Victor added the comment: I looked at test_weakref duration on buildbots before my change: * AMD64 Windows7 SP1 2.7: (less than 30 seconds) * AMD64 Windows8 2.7: 36 sec * AMD64 Windows8.1 Non-Debug 2.7: 450.6 sec Hum. That's strange. I don't understand why sometimes test_weakref hangs,

[issue29796] [2.7] test_weakref hangs on Python 2.7 on Windows

STINNER Victor added the comment: New changeset 1fef0154d97bd7f01c5bc59954a278bacf1a3f0e by Victor Stinner in branch '2.7': bpo-29796: test_weakref: Fix collect_in_thread() on Windows (#2553) https://github.com/python/cpython/commit/1fef0154d97bd7f01c5bc59954a278bacf1a3f0e -- ___

[issue29796] [2.7] test_weakref hangs on Python 2.7 on Windows

STINNER Victor added the comment: Another option is to change time.sleep() rounding, but it would impact all Python2 code using sleep()... I dislike this option. I expect many complains from users about such backward incompatible change in a minor release. -- _

[issue29796] [2.7] test_weakref hangs on Python 2.7 on Windows

STINNER Victor added the comment: @Antoine: Another example of performance issue caused by rounding ;-) See also my article on pytime and timestamp rounding, https://haypo.github.io/pytime.html -- ___ Python tracker

[issue29796] [2.7] test_weakref hangs on Python 2.7 on Windows

STINNER Victor added the comment: On Python 3, time.sleep(seconds) rounds seconds towards +Infinity: see bpo-22117, commot cb29f0177c91ebb739b89d8cc4ba223785c94d61. time.sleep(0.0001) sleeps 15.6 ms on Windows. On Python 2.7, time.sleep(seconds) rounds towards zero. time.sleep(0.0001) sleeps

[issue29796] [2.7] test_weakref hangs on Python 2.7 on Windows

Changes by STINNER Victor : -- pull_requests: +2622 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue29796] [2.7] test_weakref hangs on Python 2.7 on Windows

STINNER Victor added the comment: The problem are the 3 tests of test_weakref which uses collect_in_thread(): * test_threaded_weak_valued_setdefault(): 50k iterations * test_threaded_weak_valued_pop(): 50k iterations * test_threaded_weak_valued_consistency(): 200k iterations On my Linux with Py

[issue29796] [2.7] test_weakref hangs on Python 2.7 on Windows

STINNER Victor added the comment: Another example (I checked, all tests are run except of test_weakref): http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%202.7/builds/148/steps/test/logs/stdio ... 0:05:30 [400/403] test_file_eintr passed 0:05:30 [401/403] test_glob passed 0:05:54