[issue29927] Unnecessary code in the c-api/exceptions.c

Changes by Xiang Zhang : -- versions: -Python 3.5, Python 3.6 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue29927] Unnecessary code in the c-api/exceptions.c

Changes by Xiang Zhang : -- status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue29927] Unnecessary code in the c-api/exceptions.c

Xiang Zhang added the comment: Since the unnecessary codes have no semantic effect, I think they only need to go in 3.7. Thanks for your report and patch! -- resolution: -> fixed stage: -> resolved ___ Python tracker

[issue29927] Unnecessary code in the c-api/exceptions.c

Xiang Zhang added the comment: New changeset c431854a0963d4ec2875efab2d2425a738895280 by Xiang Zhang (Louie Lu) in branch 'master': bpo-29927: Remove duplicate BufferError init and unnecessary semicolons (GH-866) https://github.com/python/cpython/commit/c431854a0963d4ec2875efab2d2425a738895280

[issue29927] Unnecessary code in the c-api/exceptions.c

Changes by Louie Lu : -- pull_requests: +767 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue29927] Unnecessary code in the c-api/exceptions.c

Louie Lu added the comment: It seems somehow the patch at #3295 make the mistake, commit faa54a39295 at 2007-08-19 add the PRE_INIT(BufferError) and POST_INIT(BufferError), but in #3295 `buffererror.patch` didn't saw it. -- nosy: +louielu ___ Python

[issue29927] Unnecessary code in the c-api/exceptions.c

New submission from Kinebuchi Tomohiko: 1. BufferError is PRE_INIT'ed twice, and also POST_INIT'ed twice. 2. Using macros (PRE_INIT, POST_INIT and ADD_ERRNO) with following unnecessary semicolons. These unnecessary code have no semantic effect, but is somehow confusing. -- components: