[issue30000] Inconsistency in the zlib module

Xiang Zhang added the comment: Since Martin and Gregory support it, Ellison if you'd like you could make a PR for it. But code change alone is not enough. You need also adding corresponding tests and docs. -- ___ Python tracker

[issue30000] Inconsistency in the zlib module

Gregory P. Smith added the comment: I think adding these parameters to the zlib.compress() function is a fine addition for 3.7. They are more convenient for those (few) who do need them. I'd go ahead and turn it into a cpython PR. -- nosy: +gregory.p.smith ___

[issue30000] Inconsistency in the zlib module

Ellison Marks added the comment: Erm, is there anyone else we should poke for their opinion then? -- ___ Python tracker ___ ___ Python

[issue30000] Inconsistency in the zlib module

Martin Panter added the comment: I don’t have a strong opinion on adding the missing parameters to the one-shot “compress” function, though it does seem beneficial to have a consistent set of parameters supported across the relevant APIs. -- ___ Pyt

[issue30000] Inconsistency in the zlib module

Ellison Marks added the comment: I'm not sure I agree with that. The docs for compressobj just say "Returns a compression object, to be used for compressing data streams that won’t fit into memory at once." Which I don't think says much about the complexity aspect. Whether you're compressing

[issue30000] Inconsistency in the zlib module

Xiang Zhang added the comment: Such a change in my mind is an enhancement and only could get into 3.7. IMHO zlib.compress() and zlib.decompress() are for simple usage, zlib.compressobj() and zlib.decompressobj() for advanced usage if you want more controls. Actually I would prefer simplifying

[issue30000] Inconsistency in the zlib module

Ellison Marks added the comment: I made a try at a patch for this. My C is rudimentary at best, so I was hoping someone could look it over before I submitted a PR? https://github.com/gotyaoi/cpython/commit/2906fc9069ce6ec4888a547b5088ef9177a21c9a -- __

[issue30000] Inconsistency in the zlib module

New submission from Ellison Marks: In the zlib module, three of the methods support the wbits parameter, those being zlib.compressobj, zlib.decompress and zlib.decompressobj. zlib.compress does not support the wbits parameter. Looking at the source for these functions, those that support the w