[issue30233] [3.5] Warning -- locale was modified by test_idle

2017-05-03 Thread Terry J. Reedy
Terry J. Reedy added the comment: Thanks, I feel better now. This might end up being the only IDLE patch for 3.5. A test issue for git CI with respect to tkinter and IDLE has been that Travis on Linux does not run 'gui' tests, so it is semi-useless for tk and IDLE. I notice on PR 1397 that A

[issue30233] [3.5] Warning -- locale was modified by test_idle

2017-05-03 Thread STINNER Victor
STINNER Victor added the comment: > If you can load any existing file into the editor, edit a bit, or maybe cut > it down to a print statement, save under a new name, and run it, that should > be enough. I created a latin1 file with a "# coding: latin1" cookie header. I was able to open it in

[issue30233] [3.5] Warning -- locale was modified by test_idle

2017-05-03 Thread Terry J. Reedy
Terry J. Reedy added the comment: If you can load any existing file into the editor, edit a bit, or maybe cut it down to a print statement, save under a new name, and run it, that should be enough. -- ___ Python tracker

[issue30233] [3.5] Warning -- locale was modified by test_idle

2017-05-03 Thread STINNER Victor
STINNER Victor added the comment: > Victor, I forgot to ask. Did you properly test IDLE before committing the > patch? This means building python 3.5, starting IDLE, and exercising the > modules affected. test_idle is nowhere nearly a substitute for such > hand-testing. This is a big part

[issue30233] [3.5] Warning -- locale was modified by test_idle

2017-05-02 Thread Terry J. Reedy
Terry J. Reedy added the comment: Victor, I forgot to ask. Did you properly test IDLE before committing the patch? This means building python 3.5, starting IDLE, and exercising the modules affected. test_idle is nowhere nearly a substitute for such hand-testing. This is a big part of the '

[issue30233] [3.5] Warning -- locale was modified by test_idle

2017-05-02 Thread Terry J. Reedy
Terry J. Reedy added the comment: I see. That changes the situation a bit. -- ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue30233] [3.5] Warning -- locale was modified by test_idle

2017-05-02 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- assignee: -> haypo resolution: -> fixed stage: -> resolved status: open -> closed type: -> behavior ___ Python tracker ___

[issue30233] [3.5] Warning -- locale was modified by test_idle

2017-05-02 Thread STINNER Victor
STINNER Victor added the comment: > I intentionally did not patch 3.5 and merge forward because the warning was > neither unique nor a failure, I modified buildbots to log warnings in all branches. I'm now fixing all warnings to be able to identify quickly real bugs. The warning is reproduced

[issue30233] [3.5] Warning -- locale was modified by test_idle

2017-05-02 Thread STINNER Victor
Changes by STINNER Victor : -- pull_requests: +1506 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue30233] [3.5] Warning -- locale was modified by test_idle

2017-05-02 Thread Terry J. Reedy
Terry J. Reedy added the comment: The warning, which became a failure in 3.6, was averted for 3.6 by #27372. I intentionally did not patch 3.5 and merge forward because the warning was neither unique nor a failure, while adding the merge would have been a considerable bother. Also, I anticip

[issue30233] [3.5] Warning -- locale was modified by test_idle

2017-05-02 Thread STINNER Victor
New submission from STINNER Victor: Importing idlelib.IOBinding modifies the LC_CTYPE locale. For example, this module is imported by idlelib.EditorWindow which is imported by idlelib.idle_test.test_formatparagraph. As a consequence, running test_idle changes locales and the following warning