[issue30257] _bsddb: else misleadingly indented

Changes by STINNER Victor : -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___

[issue30257] _bsddb: else misleadingly indented

STINNER Victor added the comment: I don't understand well the consequence of the change, so I didn't document it in Misc/NEWS :-) -- ___ Python tracker

[issue30257] _bsddb: else misleadingly indented

STINNER Victor added the comment: New changeset 2c27731901003cbcc64056fe9db725abe8484616 by Victor Stinner in branch '2.7': bpo-30257: _bsddb: Fix newDBObject() (#1428) https://github.com/python/cpython/commit/2c27731901003cbcc64056fe9db725abe8484616 --

[issue30257] _bsddb: else misleadingly indented

Serhiy Storchaka added the comment: It looks to me that the valid combinations of getReturnsNone and cursorSetReturnsNone flags are 00, 10 and 11. But this suspicious code allows to get 01. It looks as a bug to me. -- nosy: +serhiy.storchaka ___

[issue30257] _bsddb: else misleadingly indented

Changes by Gregory P. Smith : -- nosy: +jcea -gregory.p.smith ___ Python tracker ___ ___

[issue30257] _bsddb: else misleadingly indented

Changes by STINNER Victor : -- nosy: +gregory.p.smith ___ Python tracker ___ ___

[issue30257] _bsddb: else misleadingly indented

STINNER Victor added the comment: The second line in the else block was added... 14 years ago (!) by this commit: commit 455d46f0d921337405ebd3a098c210f3614ae77c Author: Gregory P. Smith Date: Wed Jul 9 04:45:59 2003 + bsddb 4.1.6: * Extended DB &

[issue30257] _bsddb: else misleadingly indented

Changes by STINNER Victor : -- pull_requests: +1533 ___ Python tracker ___ ___

[issue30257] _bsddb: else misleadingly indented

New submission from STINNER Victor: building '_bsddb' extension gcc -pthread -fPIC -fno-strict-aliasing -O0 -g -O0 -Wall -Wstrict-prototypes -I/usr/include -I. -IInclude -I./Include -I/usr/local/include -I/home/haypo/prog/python/2.7/Include -I/home/haypo/prog/python/2.7 -c