[issue30336] Pull Requests need more detail

2017-05-11 Thread Brett Cannon
Brett Cannon added the comment: OK, since Victor has verified my thinking wasn't totally off-target, I'm going to close this. Thanks for the idea and taking the time for the PR, Jensen. If you do want to file issues or PRs against the devguide, the repo is at

[issue30336] Pull Requests need more detail

2017-05-10 Thread STINNER Victor
STINNER Victor added the comment: > What is this pull request for? I didn't notice so many PR without useful commit message (PR description). Not sure that it's useful. > Include version updates if necessary. I don't understand this part. > Make sure you have signed the CLA agreement before

[issue30336] Pull Requests need more detail

2017-05-10 Thread Brett Cannon
Brett Cannon added the comment: I'm not sure if this is going to be useful enough to force all contributors to deal with. Justification for a change should be on bugs.python.org and that's mentioned in the CONTRIBUTING.md guidelines. As for testing, the Travis/AppVeyor failures should

[issue30336] Pull Requests need more detail

2017-05-10 Thread Roundup Robot
Changes by Roundup Robot : -- pull_requests: +1638 ___ Python tracker ___

[issue30336] Pull Requests need more detail

2017-05-10 Thread Jensen Taylor
New submission from Jensen Taylor: Made a PR for this -- messages: 293447 nosy: Jensen Taylor priority: normal severity: normal status: open title: Pull Requests need more detail type: enhancement ___ Python tracker